Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8600002: More OWNERS for various printing directories. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews, gene, dpapad, kmadhusu, vandebo (ex-Chrome)
Visibility:
Public.

Description

More OWNERS for various printing directories. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110736

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
A chrome/browser/printing/OWNERS View 1 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/printing/cloud_print/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
M printing/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
abodenha: you get to LG this everyone else in the OWNERS files: reply if you ...
9 years, 1 month ago (2011-11-18 01:24:48 UTC) #1
Albert Bodenhamer
lgtm http://codereview.chromium.org/8600002/diff/1/chrome/browser/printing/OWNERS File chrome/browser/printing/OWNERS (right): http://codereview.chromium.org/8600002/diff/1/chrome/browser/printing/OWNERS#newcode2 chrome/browser/printing/OWNERS:2: abodenha@chromium.org Should probably also include gene@chromium.org and scottbyer@chromium.org
9 years, 1 month ago (2011-11-18 17:33:30 UTC) #2
Lei Zhang
On 2011/11/18 17:33:30, Albert Bodenhamer wrote: > lgtm > > http://codereview.chromium.org/8600002/diff/1/chrome/browser/printing/OWNERS > File chrome/browser/printing/OWNERS (right): ...
9 years, 1 month ago (2011-11-18 19:30:42 UTC) #3
Scott Byer
9 years, 1 month ago (2011-11-18 19:35:36 UTC) #4 
LGTM

On 2011/11/18 19:30:42, Lei Zhang wrote:
> On 2011/11/18 17:33:30, Albert Bodenhamer wrote:
> > lgtm
> > 
> > http://codereview.chromium.org/8600002/diff/1/chrome/browser/printing/OWNERS
> > File chrome/browser/printing/OWNERS (right):
> > 
> >
>
http://codereview.chromium.org/8600002/diff/1/chrome/browser/printing/OWNERS#...
> > chrome/browser/printing/OWNERS:2: mailto:abodenha@chromium.org
> > Should probably also include mailto:gene@chromium.org and
> mailto:scottbyer@chromium.org
> 
> Sure, added you guys to src/printing/OWNERS too.

Powered by Google App Engine
This is Rietveld 408576698