Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 8599006: Add flag --collect-megamorphic-maps-from-stub-cache to help diagnose a (Closed)

Created:
9 years, 1 month ago by Erik Corry
Modified:
9 years, 1 month ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Add flag --collect-megamorphic-maps-from-stub-cache to help diagnose a memory leak. Committed: http://code.google.com/p/v8/source/detail?r=10031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years, 1 month ago (2011-11-18 14:01:22 UTC) #1
Lasse Reichstein
9 years, 1 month ago (2011-11-18 14:05:25 UTC) #2
Why add a flag for that?
It's just one condition that you have to change when you test it, and then it'll
stay there forever and add yet another dynamic condition.

But LGTM, if you really want it as a flag.

Powered by Google App Engine
This is Rietveld 408576698