aura: Add glib dependency when appropriate.

aura: Add glib dependency when appropriate.

BUG=none
TEST=browser_tests, unit_tests etc. builds

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110762

[sky, 2011-11-18 17:26:22]

http://codereview.chromium.org/8599003/diff/1002/content/content_tests.gypi
File content/content_tests.gypi (right):

http://codereview.chromium.org/8599003/diff/1002/content/content_tests.gypi#n...
content/content_tests.gypi:118: ['use_glib == 1', {
I'm very surprised we need this here. Shouldn't someone be depending upon base
which has this dependency for us? I'm sure I don't understand how dependencies
in gyp.

[sadrul, 2011-11-18 17:31:03]

http://codereview.chromium.org/8599003/diff/1002/content/content_tests.gypi
File content/content_tests.gypi (right):

http://codereview.chromium.org/8599003/diff/1002/content/content_tests.gypi#n...
content/content_tests.gypi:118: ['use_glib == 1', {
On 2011/11/18 17:26:22, sky wrote:
> I'm very surprised we need this here. Shouldn't someone be depending upon base
> which has this dependency for us? I'm sure I don't understand how dependencies
> in gyp.

Indeed. I am surprised we need this too. And I am also surprised that the FYI
bots are not failing (perhaps it will show up with a clobber build?)

The 'test_support_content' target does not depend on 'base'. I tried adding the
dependency since that seemed more appropriate, but that causes other gyp errors
that I can't make any sense of. So I went with the easy way out and did the same
thing that's done for gtk above.

[sky, 2011-11-18 18:56:53]

LGTM