Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 8598027: Handle mouselock allowed in content settings while fullscreen is not. (Closed)

Created:
9 years, 1 month ago by scheib
Modified:
9 years ago
Reviewers:
Peter Kasting, yzshen1, sky
CC:
chromium-reviews, koz (OOO until 15th September), jeremya
Visibility:
Public.

Description

Handle mouselock allowed in content settings while fullscreen is not. BUG=103982 TEST=Go to a page with mouse lock and allow full screen & mouse lock; Remove permission for full screen only from content settings; test trying to go full screen and mouselock forces you to "accept" in the infobubble and isn't automatically approved. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111459

Patch Set 1 #

Patch Set 2 : Rebase to tip of tree; code moved from browser.cc to fullscreen_controller.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/fullscreen_controller.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scheib
yzshen: logic review sky: owner
9 years, 1 month ago (2011-11-18 21:57:14 UTC) #1
yzshen1
lgtm Thanks for fixing this!
9 years, 1 month ago (2011-11-18 22:03:50 UTC) #2
scheib
Peter, can you give an OWNERS review on this?
9 years ago (2011-11-23 21:34:28 UTC) #3
Peter Kasting
LGTM
9 years ago (2011-11-23 23:05:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/8598027/1
9 years ago (2011-11-23 23:13:22 UTC) #5
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/browser.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/browser.cc ...
9 years ago (2011-11-23 23:13:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/8598027/7001
9 years ago (2011-11-23 23:29:14 UTC) #7
commit-bot: I haz the power
9 years ago (2011-11-24 01:02:02 UTC) #8
Change committed as 111459

Powered by Google App Engine
This is Rietveld 408576698