Changed dangerous downloading to use .jar files.

Changed dangerous downloading to use .jar files.

BUG=104741
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110809

[Randy Smith (Not in Mondays), 2011-11-18 21:19:00]

Nirnimesh: PTAL?  I'm specifically interested in what level of testing you think
I should do for this change--I ran the testSaveDangerousFile pyauto test before
making the change (failed) and after (passed), but I'm not sure try bots have
anything to tell me here.  Anything else you think I should do?

[Nirnimesh, 2011-11-18 21:39:24]

LGTM.

Yes, your before/after testing is enough.

http://codereview.chromium.org/8598026/diff/1/chrome/test/functional/download...
File chrome/test/functional/downloads.py (right):

http://codereview.chromium.org/8598026/diff/1/chrome/test/functional/download...
chrome/test/functional/downloads.py:67: return os.path.join(sub_path,
'dangerous.jar')
Could you also delete chrome/test/data/downloads/dangerous/dangerous.exe &
chrome/test/data/downloads/dangerous/invalid-dummy.dmg please?

[Randy Smith (Not in Mondays), 2011-11-18 21:43:35]

On 2011/11/18 21:39:24, Nirnimesh wrote:
> LGTM.
> 
> Yes, your before/after testing is enough.
> 
>
http://codereview.chromium.org/8598026/diff/1/chrome/test/functional/download...
> File chrome/test/functional/downloads.py (right):
> 
>
http://codereview.chromium.org/8598026/diff/1/chrome/test/functional/download...
> chrome/test/functional/downloads.py:67: return os.path.join(sub_path,
> 'dangerous.jar')
> Could you also delete chrome/test/data/downloads/dangerous/dangerous.exe &
> chrome/test/data/downloads/dangerous/invalid-dummy.dmg please?

If you're sure they're not used anywhere else, sure.  I thought about doing it,
but didn't because I couldn't come up with a good way to scan the source for
references.  (Will wait on confirmation.)

[Nirnimesh, 2011-11-18 21:48:44]

On 2011/11/18 21:43:35, rdsmith wrote:
> On 2011/11/18 21:39:24, Nirnimesh wrote:
> > LGTM.
> > 
> > Yes, your before/after testing is enough.
> > 
> >
>
http://codereview.chromium.org/8598026/diff/1/chrome/test/functional/download...
> > File chrome/test/functional/downloads.py (right):
> > 
> >
>
http://codereview.chromium.org/8598026/diff/1/chrome/test/functional/download...
> > chrome/test/functional/downloads.py:67: return os.path.join(sub_path,
> > 'dangerous.jar')
> > Could you also delete chrome/test/data/downloads/dangerous/dangerous.exe &
> > chrome/test/data/downloads/dangerous/invalid-dummy.dmg please?
> 
> If you're sure they're not used anywhere else, sure.  I thought about doing
it,
> but didn't because I couldn't come up with a good way to scan the source for
> references.  (Will wait on confirmation.)

Ah. dangerous.exe is used elsewhere. But invalid-dummy.dmg is not. So it should
be fine to delete just invalid-dummy.dmg

[Randy Smith (Not in Mondays), 2011-11-18 22:35:47]

On 2011/11/18 21:48:44, Nirnimesh wrote:
> On 2011/11/18 21:43:35, rdsmith wrote:
> > On 2011/11/18 21:39:24, Nirnimesh wrote:
> > > LGTM.
> > > 
> > > Yes, your before/after testing is enough.
> > > 
> > >
> >
>
http://codereview.chromium.org/8598026/diff/1/chrome/test/functional/download...
> > > File chrome/test/functional/downloads.py (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/8598026/diff/1/chrome/test/functional/download...
> > > chrome/test/functional/downloads.py:67: return os.path.join(sub_path,
> > > 'dangerous.jar')
> > > Could you also delete chrome/test/data/downloads/dangerous/dangerous.exe &
> > > chrome/test/data/downloads/dangerous/invalid-dummy.dmg please?
> > 
> > If you're sure they're not used anywhere else, sure.  I thought about doing
> it,
> > but didn't because I couldn't come up with a good way to scan the source for
> > references.  (Will wait on confirmation.)
> 
> Ah. dangerous.exe is used elsewhere. But invalid-dummy.dmg is not. So it
should
> be fine to delete just invalid-dummy.dmg

Done.

[commit-bot: I haz the power, 2011-11-18 22:36:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/8598026/5001

[commit-bot: I haz the power, 2011-11-18 22:40:56]

Try job failure for 8598026-5001 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[Nirnimesh, 2011-11-18 22:42:24]

Feel free to commit by hand. The commit queue does not run any pyauto tests
anyway.

[commit-bot: I haz the power, 2011-11-19 01:30:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/8598026/5001

[commit-bot: I haz the power, 2011-11-19 01:33:54]

Try job failure for 8598026-5001 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.