Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 8598024: Now that we are doing a hard-cut-over to Aura, remove a bunch of *Views based classes that are ob... (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, penghuang+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, James Su, dhollowa
Visibility:
Public.

Description

Now that we are doing a hard-cut-over to Aura, remove a bunch of *Views based classes that are obsoleted by Aura. Also remove a bunch of Wayland stuff, since any future Wayland integration is likely done as an implementation detail of Aura, not Views. Specifically: - views-desktop (classes and NativeWidgetView[s]) - NativeWidgetViews subclasses in Chrome (Constrained Windows, NTCVV, NTCCV, BrowserFrameViews et al). - RWHVV, NWKEV - NativeViewHostViews BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110832

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -6843 lines) Patch
M build/all.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chrome_browser_parts_views.cc View 1 2 3 4 5 6 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 3 4 5 6 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 1 2 3 4 5 6 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/renderer_host/render_widget_host_view_views.h View 1 2 3 4 5 6 1 chunk +0 lines, -319 lines 0 comments Download
D chrome/browser/renderer_host/render_widget_host_view_views.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1166 lines 0 comments Download
D chrome/browser/renderer_host/render_widget_host_view_views_touch.cc View 1 2 3 4 5 6 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/browser/renderer_host/render_widget_host_view_views_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bubble/bubble.h View 1 2 3 4 5 6 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble.cc View 1 2 3 4 5 6 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.h View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 2 3 4 5 6 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 3 4 5 6 1 chunk +2 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/dom_view.cc View 1 2 3 4 5 6 2 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_gtk.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_frame_views.h View 1 2 3 4 5 6 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_frame_views.cc View 1 2 3 4 5 6 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/menu_model_adapter_test.cc View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/native_constrained_window_views.cc View 1 2 3 4 5 6 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_container_views.h View 1 2 3 4 5 6 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_container_views.cc View 1 2 3 4 5 6 1 chunk +0 lines, -140 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_view_views.h View 1 2 3 4 5 6 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_view_views.cc View 1 2 3 4 5 6 1 chunk +0 lines, -133 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 12 chunks +0 lines, -24 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/common/native_web_keyboard_event_views.h View 1 2 3 4 5 6 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/common/native_web_keyboard_event_views.cc View 1 2 3 4 5 6 1 chunk +0 lines, -93 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -16 lines 0 comments Download
D ui/views/aura_desktop/aura_desktop_main.cc View 1 2 3 4 5 6 1 chunk +0 lines, -188 lines 0 comments Download
D ui/views/desktop/desktop_background.h View 1 2 3 4 5 6 1 chunk +0 lines, -29 lines 0 comments Download
D ui/views/desktop/desktop_background.cc View 1 2 3 4 5 6 1 chunk +0 lines, -55 lines 0 comments Download
D ui/views/desktop/desktop_main.cc View 1 2 3 4 5 6 1 chunk +0 lines, -90 lines 0 comments Download
D ui/views/desktop/desktop_views_delegate.h View 1 2 3 4 5 6 1 chunk +0 lines, -51 lines 0 comments Download
D ui/views/desktop/desktop_views_delegate.cc View 1 2 3 4 5 6 1 chunk +0 lines, -76 lines 0 comments Download
D ui/views/desktop/desktop_window_manager.h View 1 2 3 4 5 6 1 chunk +0 lines, -99 lines 0 comments Download
D ui/views/desktop/desktop_window_manager.cc View 1 2 3 4 5 6 1 chunk +0 lines, -305 lines 0 comments Download
D ui/views/desktop/desktop_window_view.h View 1 2 3 4 5 6 1 chunk +0 lines, -100 lines 0 comments Download
D ui/views/desktop/desktop_window_view.cc View 1 2 3 4 5 6 1 chunk +0 lines, -295 lines 0 comments Download
D ui/views/events/event_wayland.cc View 1 2 3 4 5 6 1 chunk +0 lines, -23 lines 0 comments Download
M ui/views/examples/examples_main.cc View 1 2 3 4 5 6 2 chunks +0 lines, -2 lines 0 comments Download
D ui/views/focus/accelerator_handler_touch.cc View 1 2 3 4 5 6 1 chunk +0 lines, -188 lines 0 comments Download
D ui/views/ime/input_method_wayland.h View 1 2 3 4 5 6 1 chunk +0 lines, -36 lines 0 comments Download
D ui/views/ime/input_method_wayland.cc View 1 2 3 4 5 6 1 chunk +0 lines, -76 lines 0 comments Download
M ui/views/test/test_views_delegate.h View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 2 3 4 5 6 2 chunks +1 line, -6 lines 0 comments Download
M ui/views/touchui/gesture_manager.cc View 1 2 3 4 5 6 2 chunks +10 lines, -22 lines 0 comments Download
D views/controls/combobox/native_combobox_wayland.cc View 1 2 3 4 5 6 1 chunk +0 lines, -15 lines 0 comments Download
M views/controls/native/native_view_host.h View 1 2 3 4 5 6 3 chunks +0 lines, -11 lines 0 comments Download
M views/controls/native/native_view_host.cc View 1 2 3 4 5 6 6 chunks +2 lines, -21 lines 0 comments Download
M views/controls/native/native_view_host_gtk.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
D views/controls/native/native_view_host_views.h View 1 2 3 4 5 6 1 chunk +0 lines, -47 lines 0 comments Download
D views/controls/native/native_view_host_views.cc View 1 2 3 4 5 6 1 chunk +0 lines, -82 lines 0 comments Download
D views/controls/native/native_view_host_wayland.cc View 1 2 3 4 5 6 1 chunk +0 lines, -16 lines 0 comments Download
D views/metrics_wayland.cc View 1 2 3 4 5 6 1 chunk +0 lines, -17 lines 0 comments Download
M views/view.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M views/view_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -48 lines 0 comments Download
views/view_wayland.cc View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
M views/views.gyp View 1 2 3 4 5 6 13 chunks +0 lines, -201 lines 0 comments Download
M views/views_delegate.h View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M views/widget/native_widget_aura.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M views/widget/native_widget_delegate.h View 1 2 3 4 5 6 1 chunk +5 lines, -6 lines 0 comments Download
M views/widget/native_widget_gtk.cc View 1 2 3 4 5 6 5 chunks +3 lines, -16 lines 0 comments Download
views/widget/native_widget_view.h View 1 2 3 4 5 6 1 chunk +0 lines, -101 lines 0 comments Download
D views/widget/native_widget_view.cc View 1 2 3 4 5 6 1 chunk +0 lines, -178 lines 0 comments Download
D views/widget/native_widget_views.h View 1 2 3 4 5 6 1 chunk +0 lines, -190 lines 0 comments Download
D views/widget/native_widget_views.cc View 1 2 3 4 5 6 1 chunk +0 lines, -648 lines 0 comments Download
D views/widget/native_widget_wayland.h View 1 2 3 4 5 6 1 chunk +0 lines, -215 lines 0 comments Download
D views/widget/native_widget_wayland.cc View 1 2 3 4 5 6 1 chunk +0 lines, -683 lines 0 comments Download
M views/widget/native_widget_win.cc View 1 2 3 4 5 6 2 chunks +0 lines, -5 lines 0 comments Download
M views/widget/widget_unittest.cc View 1 2 3 4 5 6 28 chunks +94 lines, -144 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
9 years, 1 month ago (2011-11-18 23:34:52 UTC) #1
sky
Rubber stamp LGTM
9 years, 1 month ago (2011-11-18 23:59:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8598024/12086
9 years, 1 month ago (2011-11-19 00:29:38 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-19 00:30:37 UTC) #4
Can't process patch for file views/widget/native_widget_view.h.
File's status is None, patchset upload is incomplete.

Powered by Google App Engine
This is Rietveld 408576698