Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/common/extensions/extension_permission_set_unittest.cc

Issue 8598022: Restrict access to permissions based on extension types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_permission_set.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_permission_set_unittest.cc
diff --git a/chrome/common/extensions/extension_permission_set_unittest.cc b/chrome/common/extensions/extension_permission_set_unittest.cc
index eae7b4584e27dc7be14ff771937b58ac217b0a59..a797c7649dd71cc6424aad7b997eed44dc95a347 100644
--- a/chrome/common/extensions/extension_permission_set_unittest.cc
+++ b/chrome/common/extensions/extension_permission_set_unittest.cc
@@ -158,11 +158,35 @@ TEST(ExtensionAPIPermissionTest, HostedAppPermissions) {
for (ExtensionAPIPermissionSet::iterator i = perms.begin();
i != perms.end(); ++i) {
count += hosted_perms.count(*i);
- EXPECT_EQ(hosted_perms.count(*i) > 0, info->GetByID(*i)->is_hosted_app());
+ EXPECT_EQ(hosted_perms.count(*i) > 0,
+ info->GetByID(*i)->supports_hosted_apps());
}
EXPECT_EQ(hosted_perms.size(), count);
- EXPECT_EQ(hosted_perms.size(), info->get_hosted_app_permission_count());
+}
+
+TEST(ExtensionAPIPermissionTest, PlatformAppPermissions) {
+ ExtensionPermissionsInfo* info = ExtensionPermissionsInfo::GetInstance();
+ ExtensionAPIPermissionSet blacklist;
+ blacklist.insert(ExtensionAPIPermission::kChromeAuthPrivate);
+ blacklist.insert(ExtensionAPIPermission::kChromePrivate);
+ blacklist.insert(ExtensionAPIPermission::kCookie);
+ blacklist.insert(ExtensionAPIPermission::kTab);
+ blacklist.insert(ExtensionAPIPermission::kWebNavigation);
+ blacklist.insert(ExtensionAPIPermission::kWebRequest);
+ blacklist.insert(ExtensionAPIPermission::kWebRequestBlocking);
+ blacklist.insert(ExtensionAPIPermission::kWebSocketProxyPrivate);
+
+ ExtensionAPIPermissionSet perms = info->GetAll();
+ size_t count = 0;
+ for (ExtensionAPIPermissionSet::iterator i = perms.begin();
+ i != perms.end(); ++i) {
+ count += blacklist.count(*i);
+ EXPECT_EQ(blacklist.count(*i) > 0,
+ !info->GetByID(*i)->supports_platform_apps());
+ }
+
+ EXPECT_EQ(blacklist.size(), count);
}
TEST(ExtensionAPIPermissionTest, ComponentOnlyPermissions) {
« no previous file with comments | « chrome/common/extensions/extension_permission_set.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698