Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5876)

Unified Diff: chrome/common/extensions/extension.h

Issue 8598022: Restrict access to permissions based on extension types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 4cb0fbe8f6cf7493d0768c3c708baa298d7dbd48..a0ec6d8efacb7e46626e1a7bac621f65c5d73998 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -560,7 +560,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool is_app() const { return is_app_; }
bool is_platform_app() const { return is_platform_app_; }
bool is_hosted_app() const { return is_app() && !web_extent().is_empty(); }
- bool is_packaged_app() const { return is_app() && web_extent().is_empty(); }
+ bool is_packaged_app() const {
+ return !is_platform_app() && is_app() && web_extent().is_empty();
+ }
bool is_storage_isolated() const { return is_app() && is_storage_isolated_; }
const URLPatternSet& web_extent() const { return extent_; }
const std::string& launch_local_path() const { return launch_local_path_; }
@@ -694,8 +696,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
std::string* error) const;
bool CanSpecifyComponentOnlyPermission() const;
bool CanSpecifyExperimentalPermission() const;
- bool CanSpecifyPermissionForHostedApp(
- const ExtensionAPIPermission* api) const;
// Checks whether the host |pattern| is allowed for this extension, given API
// permissions |permissions|.
« no previous file with comments | « chrome/browser/renderer_host/chrome_render_view_host_observer.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698