Restrict access to permissions based on extension types.

chrome/common/extensions/extension_manifests_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 635 matching lines @@
     if (permission->is_component_only()) {
       LoadAndExpectError(Manifest(manifest.get(), name),
                          errors::kPermissionNotAllowed,
                          Extension::INTERNAL);
       scoped_refptr<Extension> extension(
           LoadAndExpectSuccess(Manifest(manifest.get(), name),
                                Extension::COMPONENT));
       EXPECT_TRUE(extension->GetActivePermissions()->HasAPIPermission(
           permission->id()));
 
-    } else if (!permission->is_hosted_app()) {
+    } else if (!permission->supports_hosted_apps()) {

[Aaron Boodman, 2011/11/22 09:40:32]

I like the 'supports' nomenclature better - nice change.

[jstritar, 2011/11/22 15:58:29]

Nice, thx.

       // Most normal extension permissions also aren't available to hosted apps.
       // For these, the error is only reported in strict mode for legacy
       // reasons: crbug.com/101993.
       LoadAndExpectError(Manifest(manifest.get(), name),
                          errors::kPermissionNotAllowed,
                          Extension::INTERNAL,
                          Extension::STRICT_ERROR_CHECKS);
       scoped_refptr<Extension> extension(
           LoadAndExpectSuccess(Manifest(manifest.get(), name),
                                Extension::INTERNAL));
@@ skipping 287 matching lines @@
   scoped_refptr<Extension> extension_2(
       LoadAndExpectSuccess("offline_disabled_packaged_app.json"));
   EXPECT_FALSE(extension_2->offline_enabled());
   scoped_refptr<Extension> extension_3(
       LoadAndExpectSuccess("offline_default_packaged_app.json"));
   EXPECT_FALSE(extension_3->offline_enabled());
   scoped_refptr<Extension> extension_4(
       LoadAndExpectSuccess("offline_enabled_hosted_app.json"));
   EXPECT_TRUE(extension_4->offline_enabled());
 }