Issue 8598020: wayland: cleanup ifdef in accelerator_handle.h for use_wayland and use_aura

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8598020: wayland: cleanup ifdef in accelerator_handle.h for use_wayland and use_aura (Closed)

Created:
9 years, 1 month ago by Mandeep Singh Baines

Modified:
9 years, 1 month ago

Reviewers:
dnicoara, Jay Civelli, sky, Emmanuel Saint-loubert-Bié

CC:
chromium-reviews, tfarina, dhollowa, recbradford, Elliot Glaysher

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

wayland: cleanup ifdef in accelerator_handle.h for use_wayland and use_aura BUG=102903 TEST=compile Change-Id: Ia9780044a47c91b8172710cc92481af60433b3a1 R=sky@chromium.org,jcivelli@chromium.org,saintlou@chromium.org,dnicoara@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110748

Patch Set 2 : Fix per review nits. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	views/focus/accelerator_handler.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM with the nits cleaned up. http://codereview.chromium.org/8598020/diff/1/views/focus/accelerator_handler.h File views/focus/accelerator_handler.h (right): http://codereview.chromium.org/8598020/diff/1/views/focus/accelerator_handler.h#newcode24 views/focus/accelerator_handler.h:24: #if defined (USE_X11) ...

9 years, 1 month ago (2011-11-18 19:04:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msb@chromium.org/8598020/2002

9 years, 1 month ago (2011-11-18 19:48:07 UTC) #3

Change committed as 110748

Expand Messages | Collapse Messages

Issue 8598020: wayland: cleanup ifdef in accelerator_handle.h for use_wayland and use_aura (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix per review nits. #

Messages