History/Downloads:

History/Downloads:
- Adding button and checkbox css to history and downloads.
- Tweaked checkbox styles for history.

R=estade@chromium.org,csilv@chromium.org
BUG=None
TEST=Look at checkboxes and buttons on history/downloads without feeling
nauseous.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110834

[Dan Beam, 2011-11-19 00:19:27]

I guess this review is now optional considering the way the thread is going, but
if they're into it we can review (or if reviewed, commit).  I know this is
probably the wrong order to do this, but it was useful to prototype either
way...

[Evan Stade, 2011-11-19 00:40:40]

the thread is more concerned with settings, which is already done, and besides I
think the only concern is with the aesthetics of the checkboxes, which applies
equally everywhere but does not affect the principle that we should be sharing
styles. Hence this patch is not affected.

lgtm

http://codereview.chromium.org/8598017/diff/5001/chrome/browser/resources/his...
File chrome/browser/resources/history.html (right):

http://codereview.chromium.org/8598017/diff/5001/chrome/browser/resources/his...
chrome/browser/resources/history.html:171: margin-left: 2px;
delete

[Dan Beam, 2011-11-19 01:21:28]

http://codereview.chromium.org/8598017/diff/5001/chrome/browser/resources/his...
File chrome/browser/resources/history.html (right):

http://codereview.chromium.org/8598017/diff/5001/chrome/browser/resources/his...
chrome/browser/resources/history.html:171: margin-left: 2px;
On 2011/11/19 00:40:40, Evan Stade wrote:
> delete

Done.

[csilv, 2011-11-19 01:46:30]

lgtm

http://codereview.chromium.org/8598017/diff/11001/chrome/browser/resources/hi...
File chrome/browser/resources/history.html (right):

http://codereview.chromium.org/8598017/diff/11001/chrome/browser/resources/hi...
chrome/browser/resources/history.html:99: float: left;     /* ..but make the box
shrink to fit its content. */
This comment was previously a continuation line 101, so it kinda reads oddly
now.

[Dan Beam, 2011-11-19 02:16:32]

http://codereview.chromium.org/8598017/diff/11001/chrome/browser/resources/hi...
File chrome/browser/resources/history.html (right):

http://codereview.chromium.org/8598017/diff/11001/chrome/browser/resources/hi...
chrome/browser/resources/history.html:99: float: left;     /* ..but make the box
shrink to fit its content. */
On 2011/11/19 01:46:30, csilv wrote:
> This comment was previously a continuation line 101, so it kinda reads oddly
> now.

Done.

[commit-bot: I haz the power, 2011-11-19 04:04:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/8598017/10011

[commit-bot: I haz the power, 2011-11-19 05:02:11]

Try job failure for 8598017-10011 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, steps "check_deps, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-19 05:22:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/8598017/10011

[commit-bot: I haz the power, 2011-11-19 06:20:40]

Change committed as 110834