Index: chrome/browser/bookmarks/bookmark_model.cc |
diff --git a/chrome/browser/bookmarks/bookmark_model.cc b/chrome/browser/bookmarks/bookmark_model.cc |
index 2cf482eda964c4340efc3cfbd6559b37b78a12f6..5fd3ef4076988ee77f16028f52d94d33de26ea34 100644 |
--- a/chrome/browser/bookmarks/bookmark_model.cc |
+++ b/chrome/browser/bookmarks/bookmark_model.cc |
@@ -305,11 +305,18 @@ const SkBitmap& BookmarkModel::GetFavicon(const BookmarkNode* node) { |
} |
void BookmarkModel::SetTitle(const BookmarkNode* node, const string16& title) { |
+ string16 mutable_title = title; |
+ |
+ // Remove line break whitespace from Folder names. |
Ilya Sherman
2011/11/21 21:36:10
Hmm, why do we only want to clean up /folder/ name
KushalP
2011/11/21 22:14:15
This change was made previous to the discussions w
|
+ if (node->is_folder()) { |
+ mutable_title = CollapseWhitespace(mutable_title, false); |
+ } |
+ |
if (!node) { |
NOTREACHED(); |
return; |
} |
- if (node->GetTitle() == title) |
+ if (node->GetTitle() == mutable_title) |
return; |
if (is_permanent_node(node)) { |
@@ -320,7 +327,7 @@ void BookmarkModel::SetTitle(const BookmarkNode* node, const string16& title) { |
// The title index doesn't support changing the title, instead we remove then |
// add it back. |
index_->Remove(node); |
- AsMutable(node)->set_title(title); |
+ AsMutable(node)->set_title(mutable_title); |
index_->Add(node); |
if (store_.get()) |
@@ -436,7 +443,8 @@ const BookmarkNode* BookmarkModel::AddFolder(const BookmarkNode* parent, |
BookmarkNode* new_node = new BookmarkNode(generate_next_node_id(), GURL()); |
new_node->set_date_folder_modified(Time::Now()); |
- new_node->set_title(title); |
+ // Folders shouldn't have line breaks in their titles. |
+ new_node->set_title(CollapseWhitespace(title, false)); |
new_node->set_type(BookmarkNode::FOLDER); |
return AddNode(AsMutable(parent), index, new_node, false); |