Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4676)

Unified Diff: chrome/browser/bookmarks/bookmark_model.cc

Issue 8598015: Do not allow multiline input when naming bookmarks/folders on Mac (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: pointer placement nit; move category into header file Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_model.cc
diff --git a/chrome/browser/bookmarks/bookmark_model.cc b/chrome/browser/bookmarks/bookmark_model.cc
index 2cf482eda964c4340efc3cfbd6559b37b78a12f6..bcfa3cdee59b2a797ead3767ebb33502a64e4f6a 100644
--- a/chrome/browser/bookmarks/bookmark_model.cc
+++ b/chrome/browser/bookmarks/bookmark_model.cc
@@ -11,6 +11,7 @@
#include "base/bind_helpers.h"
#include "base/command_line.h"
#include "base/memory/scoped_vector.h"
+#include "base/string_util.h"
#include "build/build_config.h"
#include "chrome/browser/bookmarks/bookmark_expanded_state_tracker.h"
#include "chrome/browser/bookmarks/bookmark_index.h"
@@ -305,11 +306,14 @@ const SkBitmap& BookmarkModel::GetFavicon(const BookmarkNode* node) {
}
void BookmarkModel::SetTitle(const BookmarkNode* node, const string16& title) {
+ // Remove extra whitespace from folder/bookmark names.
+ string16 mutable_title = CollapseWhitespace(title, false);
+
if (!node) {
NOTREACHED();
return;
}
- if (node->GetTitle() == title)
+ if (node->GetTitle() == mutable_title)
return;
if (is_permanent_node(node)) {
@@ -320,7 +324,7 @@ void BookmarkModel::SetTitle(const BookmarkNode* node, const string16& title) {
// The title index doesn't support changing the title, instead we remove then
// add it back.
index_->Remove(node);
- AsMutable(node)->set_title(title);
+ AsMutable(node)->set_title(mutable_title);
index_->Add(node);
if (store_.get())
@@ -436,7 +440,8 @@ const BookmarkNode* BookmarkModel::AddFolder(const BookmarkNode* parent,
BookmarkNode* new_node = new BookmarkNode(generate_next_node_id(), GURL());
new_node->set_date_folder_modified(Time::Now());
- new_node->set_title(title);
+ // Folders shouldn't have line breaks in their titles.
+ new_node->set_title(CollapseWhitespace(title, false));
new_node->set_type(BookmarkNode::FOLDER);
return AddNode(AsMutable(parent), index, new_node, false);
@@ -446,7 +451,9 @@ const BookmarkNode* BookmarkModel::AddURL(const BookmarkNode* parent,
int index,
const string16& title,
const GURL& url) {
- return AddURLWithCreationTime(parent, index, title, url, Time::Now());
+ return AddURLWithCreationTime(parent, index,
+ CollapseWhitespace(title, false),
+ url, Time::Now());
}
const BookmarkNode* BookmarkModel::AddURLWithCreationTime(
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698