chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm - Issue 8598015: Do not allow multiline input when naming bookmarks/folders on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

Issue 8598015: Do not allow multiline input when naming bookmarks/folders on Mac (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: NSCell; got all folders to only accept single-line input Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bookmarks/bookmark_model_unittest.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

index 340115ad3e7424a8ab24bd76003a99851d4bbc5a..36a8033e551d2ca9b653fcf6d7b97d92debe055a 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

@@ -20,6 +20,10 @@

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/l10n/l10n_util_mac.h"

+@interface NSCell(multilinebookmarks)

+- (void)setUsesSingleLineMode:(BOOL)flag;

+@end

@interface BookmarkEditorBaseController ()

// Return the folder tree object for the given path.

@@ -564,6 +568,13 @@ class BookmarkEditorBaseControllerBridge : public BookmarkModelObserver {

[self setTableSelectionPath:selection];

NSInteger row = [folderTreeView_ selectedRow];

DCHECK(row >= 0);

+ NSCell *folderCell = [folderTreeView_ preparedCellAtColumn:0 row:row];

Ilya Sherman 2011/11/30 06:09:38 nit: "NSCell *" -> "NSCell* "

+ if ([folderCell

+ respondsToSelector:@selector(setUsesSingleLineMode:)]) {

+ [folderCell setUsesSingleLineMode:YES];

+ }

[folderTreeView_ editColumn:0 row:row withEvent:nil select:YES];

}