Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 8598014: Implement code stub for object literal creation. (Closed)

Created:
9 years, 1 month ago by Michael Starzinger
Modified:
9 years, 1 month ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Implement code stub for object literal creation. This generates code stubs for cloning of shallow object literal boilerplates that have no elements and only fast properties. Improves splay performance because object literals are created frequently. R=fschneider@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=10036

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment by Florian Schneider. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -12 lines) Patch
M src/code-stubs.h View 1 3 chunks +23 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
PTAL. So far I only ported the stub to ia32 and x64. The port to ...
9 years, 1 month ago (2011-11-18 14:21:33 UTC) #1
fschneider
lgtm http://codereview.chromium.org/8598014/diff/1/src/code-stubs.h File src/code-stubs.h (right): http://codereview.chromium.org/8598014/diff/1/src/code-stubs.h#newcode390 src/code-stubs.h:390: ASSERT(length_ >= 0); Maybe use ASSERT_GE / ASSERT_LE ...
9 years, 1 month ago (2011-11-21 12:27:03 UTC) #2
Michael Starzinger
9 years, 1 month ago (2011-11-21 13:28:14 UTC) #3
Added new patch set. Landed.

http://codereview.chromium.org/8598014/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

http://codereview.chromium.org/8598014/diff/1/src/code-stubs.h#newcode390
src/code-stubs.h:390: ASSERT(length_ >= 0);
On 2011/11/21 12:27:03, fschneider wrote:
> Maybe use ASSERT_GE / ASSERT_LE instead of ASSERT.

Done.

Powered by Google App Engine
This is Rietveld 408576698