Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: ppapi/ppapi_internal.gyp

Issue 8598010: replace platform conditions with os_posix and os_bsd where applicable (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, # Use higher warning level. 7 'chromium_code': 1, # Use higher warning level.
8 }, 8 },
9 'target_defaults': { 9 'target_defaults': {
10 'conditions': [ 10 'conditions': [
11 # Linux shared libraries should always be built -fPIC. 11 # Linux shared libraries should always be built -fPIC.
12 # 12 #
13 # TODO(ajwong): For internal pepper plugins, which are statically linked 13 # TODO(ajwong): For internal pepper plugins, which are statically linked
14 # into chrome, do we want to build w/o -fPIC? If so, how can we express 14 # into chrome, do we want to build w/o -fPIC? If so, how can we express
15 # that in the build system? 15 # that in the build system?
16 ['OS=="linux" or OS=="openbsd" or OS=="freebsd" or OS=="solaris"', { 16 ['os_posix==1 and OS!="android" and OS!="mac"', {
17 'cflags': ['-fPIC', '-fvisibility=hidden'], 17 'cflags': ['-fPIC', '-fvisibility=hidden'],
18 18
19 # This is needed to make the Linux shlib build happy. Without this, 19 # This is needed to make the Linux shlib build happy. Without this,
20 # -fvisibility=hidden gets stripped by the exclusion in common.gypi 20 # -fvisibility=hidden gets stripped by the exclusion in common.gypi
21 # that is triggered when a shared library build is specified. 21 # that is triggered when a shared library build is specified.
22 'cflags/': [['include', '^-fvisibility=hidden$']], 22 'cflags/': [['include', '^-fvisibility=hidden$']],
23 }], 23 }],
24 ], 24 ],
25 }, 25 },
26 'includes': [ 26 'includes': [
27 '../native_client/build/untrusted.gypi', 27 '../native_client/build/untrusted.gypi',
28 'ppapi_proxy.gypi', 28 'ppapi_proxy.gypi',
29 'ppapi_shared.gypi', 29 'ppapi_shared.gypi',
30 'ppapi_tests.gypi', 30 'ppapi_tests.gypi',
31 ], 31 ],
32 } 32 }
OLDNEW
« net/base/host_resolver_impl.cc ('K') | « net/net.gyp ('k') | ppapi/ppapi_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698