Issue 8597017: Switch to a simple linked-list for worker thread pool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8597017: Switch to a simple linked-list for worker thread pool (Closed)

Created:
9 years, 1 month ago by jar (doing other things)

Modified:
9 years, 1 month ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Switch to a simple linked-list for worker thread pool The goal was to avoid alloc/free during the thread teardown callback, and this CL provides a very simple and clear implementation. r=rtenneti BUG=104696 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110856

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -123 lines)			Patch
	M	base/tracked_objects.h	View	1 2 3	10 chunks	+48 lines, -52 lines	0 comments	Download
	M	base/tracked_objects.cc	View	1 2 3	7 chunks	+25 lines, -71 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

lgtm http://codereview.chromium.org/8597017/diff/4001/base/tracked_objects.h File base/tracked_objects.h (right): http://codereview.chromium.org/8597017/diff/4001/base/tracked_objects.h#newcode169 base/tracked_objects.h:169: // TODO(jar): We should support (optionally) the recording ...

9 years, 1 month ago (2011-11-18 23:33:44 UTC) #2

jar (doing other things)

9 years, 1 month ago (2011-11-18 23:57:40 UTC) #3

change made per comments by rtenneti

http://codereview.chromium.org/8597017/diff/4001/base/tracked_objects.h
File base/tracked_objects.h (right):

http://codereview.chromium.org/8597017/diff/4001/base/tracked_objects.h#newco...
base/tracked_objects.h:169: // TODO(jar): We should support (optionally) the
recording of of parent-child
On 2011/11/18 23:33:44, ramant wrote:
> nit: of of -> of

Done.

Expand Messages | Collapse Messages