Issue 8597009: Fix Clang error on SettingChange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8597009: Fix Clang error on SettingChange. (Closed)

Created:
9 years, 1 month ago by Ivan Korotkov

Modified:
9 years, 1 month ago

Reviewers:
whywhat

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Clang error on SettingChange. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110685

Patch Set 1 #

Patch Set 2 : merge #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -5 lines)			Patch
M	chrome/browser/protector/setting_change.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
A	chrome/browser/protector/setting_change.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/8597009/2001

9 years, 1 month ago (2011-11-18 11:33:08 UTC) #3

commit-bot: I haz the power

9 years, 1 month ago (2011-11-18 11:51:57 UTC) #4

Can't apply patch for file chrome/browser/protector/setting_change.h.
While running patch -p1 --forward --force;
patching file chrome/browser/protector/setting_change.h
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/protector/setting_change.h.rej

Expand Messages | Collapse Messages