sync: rename ProfileSyncFactory to ProfileSyncComponentsFactory.

chrome/browser/sync/profile_sync_components_factory_impl.cc

Index: chrome/browser/sync/profile_sync_components_factory_impl.cc
diff --git a/chrome/browser/sync/profile_sync_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc
similarity index 89%
rename from chrome/browser/sync/profile_sync_factory_impl.cc
rename to chrome/browser/sync/profile_sync_components_factory_impl.cc
index c31e2c61ed2efea6f20d8455fc22d1871b9a8bf2..d8718ddea2c02792b0e814adca2be124a9b596b5 100644
--- a/chrome/browser/sync/profile_sync_factory_impl.cc
+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc
@@ -39,7 +39,7 @@
 #include "chrome/browser/sync/glue/typed_url_change_processor.h"
 #include "chrome/browser/sync/glue/typed_url_data_type_controller.h"
 #include "chrome/browser/sync/glue/typed_url_model_associator.h"
-#include "chrome/browser/sync/profile_sync_factory_impl.h"
+#include "chrome/browser/sync/profile_sync_components_factory_impl.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/signin_manager.h"
 #include "chrome/browser/webdata/autocomplete_syncable_service.h"
@@ -82,13 +82,13 @@ using browser_sync::TypedUrlModelAssociator;
 using browser_sync::UnrecoverableErrorHandler;
 using content::BrowserThread;
 
-ProfileSyncFactoryImpl::ProfileSyncFactoryImpl(Profile* profile,
-                                               CommandLine* command_line)
+ProfileSyncComponentsFactoryImpl::ProfileSyncComponentsFactoryImpl(
+    Profile* profile, CommandLine* command_line)
     : profile_(profile),
       command_line_(command_line) {
 }
 
-ProfileSyncService* ProfileSyncFactoryImpl::CreateProfileSyncService(
+ProfileSyncService* ProfileSyncComponentsFactoryImpl::CreateProfileSyncService(
     const std::string& cros_user) {
 
   ProfileSyncService* pss = new ProfileSyncService(
@@ -96,7 +96,8 @@ ProfileSyncService* ProfileSyncFactoryImpl::CreateProfileSyncService(
   return pss;
 }
 
-void ProfileSyncFactoryImpl::RegisterDataTypes(ProfileSyncService* pss) {
+void ProfileSyncComponentsFactoryImpl::RegisterDataTypes(
+    ProfileSyncService* pss) {
   // App sync is enabled by default.  Register unless explicitly
   // disabled.
   if (!command_line_->HasSwitch(switches::kDisableSyncApps)) {
@@ -191,14 +192,14 @@ void ProfileSyncFactoryImpl::RegisterDataTypes(ProfileSyncService* pss) {
   }
 }
 
-DataTypeManager* ProfileSyncFactoryImpl::CreateDataTypeManager(
+DataTypeManager* ProfileSyncComponentsFactoryImpl::CreateDataTypeManager(
     SyncBackendHost* backend,
     const DataTypeController::TypeMap* controllers) {
   return new DataTypeManagerImpl(backend, controllers);
 }
 
 browser_sync::GenericChangeProcessor*
-    ProfileSyncFactoryImpl::CreateGenericChangeProcessor(
+    ProfileSyncComponentsFactoryImpl::CreateGenericChangeProcessor(
         ProfileSyncService* profile_sync_service,
         browser_sync::UnrecoverableErrorHandler* error_handler,
         const base::WeakPtr<SyncableService>& local_service) {
@@ -208,13 +209,13 @@ browser_sync::GenericChangeProcessor*
                                     user_share);
 }
 
-browser_sync::SharedChangeProcessor* ProfileSyncFactoryImpl::
+browser_sync::SharedChangeProcessor* ProfileSyncComponentsFactoryImpl::
     CreateSharedChangeProcessor() {
   return new SharedChangeProcessor();
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreateAppSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreateAppSyncComponents(

[Nicolas Zea, 2011/11/22 00:01:03]

although all the methods in this file match this format, indent by 4 spaces
here?

[tim (not reviewing), 2011/11/22 00:38:20]

think we'd generally say consistency trumps the rule here :/ I suppose i can
change them all, if you really want to overturn the decision :)

     ProfileSyncService* profile_sync_service,
     UnrecoverableErrorHandler* error_handler) {
   base::WeakPtr<SyncableService> app_sync_service =
@@ -230,19 +231,19 @@ ProfileSyncFactoryImpl::CreateAppSyncComponents(
 }
 
 base::WeakPtr<SyncableService>
-ProfileSyncFactoryImpl::GetAutofillProfileSyncableService(
+ProfileSyncComponentsFactoryImpl::GetAutofillProfileSyncableService(
     WebDataService* web_data_service) const {
   return web_data_service->GetAutofillProfileSyncableService()->AsWeakPtr();
 }
 
 base::WeakPtr<SyncableService>
-ProfileSyncFactoryImpl::GetAutocompleteSyncableService(
+ProfileSyncComponentsFactoryImpl::GetAutocompleteSyncableService(
     WebDataService* web_data_service) const {
   return web_data_service->GetAutocompleteSyncableService()->AsWeakPtr();
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreateBookmarkSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreateBookmarkSyncComponents(
     ProfileSyncService* profile_sync_service,
     UnrecoverableErrorHandler* error_handler) {
   BookmarkModel* bookmark_model =
@@ -258,8 +259,8 @@ ProfileSyncFactoryImpl::CreateBookmarkSyncComponents(
   return SyncComponents(model_associator, change_processor);
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreateExtensionOrAppSettingSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreateExtensionOrAppSettingSyncComponents(
     syncable::ModelType type,
     SyncableService* settings_service,
     ProfileSyncService* profile_sync_service,
@@ -279,8 +280,8 @@ ProfileSyncFactoryImpl::CreateExtensionOrAppSettingSyncComponents(
   return SyncComponents(sync_service_adapter, change_processor);
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreateExtensionSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreateExtensionSyncComponents(
     ProfileSyncService* profile_sync_service,
     UnrecoverableErrorHandler* error_handler) {
   base::WeakPtr<SyncableService> extension_sync_service =
@@ -297,8 +298,8 @@ ProfileSyncFactoryImpl::CreateExtensionSyncComponents(
   return SyncComponents(sync_service_adapter, change_processor);
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreatePasswordSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreatePasswordSyncComponents(
     ProfileSyncService* profile_sync_service,
     PasswordStore* password_store,
     UnrecoverableErrorHandler* error_handler) {
@@ -312,8 +313,8 @@ ProfileSyncFactoryImpl::CreatePasswordSyncComponents(
   return SyncComponents(model_associator, change_processor);
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreatePreferenceSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreatePreferenceSyncComponents(
     ProfileSyncService* profile_sync_service,
     UnrecoverableErrorHandler* error_handler) {
   base::WeakPtr<SyncableService> pref_sync_service =
@@ -330,8 +331,8 @@ ProfileSyncFactoryImpl::CreatePreferenceSyncComponents(
   return SyncComponents(sync_service_adapter, change_processor);
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreateThemeSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreateThemeSyncComponents(
     ProfileSyncService* profile_sync_service,
     UnrecoverableErrorHandler* error_handler) {
   ThemeModelAssociator* model_associator =
@@ -341,8 +342,8 @@ ProfileSyncFactoryImpl::CreateThemeSyncComponents(
   return SyncComponents(model_associator, change_processor);
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreateTypedUrlSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreateTypedUrlSyncComponents(
     ProfileSyncService* profile_sync_service,
     history::HistoryBackend* history_backend,
     browser_sync::UnrecoverableErrorHandler* error_handler) {
@@ -357,8 +358,8 @@ ProfileSyncFactoryImpl::CreateTypedUrlSyncComponents(
   return SyncComponents(model_associator, change_processor);
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreateSessionSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreateSessionSyncComponents(
     ProfileSyncService* profile_sync_service,
     UnrecoverableErrorHandler* error_handler) {
   SessionModelAssociator* model_associator =
@@ -368,8 +369,8 @@ ProfileSyncFactoryImpl::CreateSessionSyncComponents(
   return SyncComponents(model_associator, change_processor);
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreateSearchEngineSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreateSearchEngineSyncComponents(
     ProfileSyncService* profile_sync_service,
     UnrecoverableErrorHandler* error_handler) {
   base::WeakPtr<SyncableService> se_sync_service =
@@ -387,8 +388,8 @@ ProfileSyncFactoryImpl::CreateSearchEngineSyncComponents(
   return SyncComponents(sync_service_adapter, change_processor);
 }
 
-ProfileSyncFactory::SyncComponents
-ProfileSyncFactoryImpl::CreateAppNotificationSyncComponents(
+ProfileSyncComponentsFactory::SyncComponents
+ProfileSyncComponentsFactoryImpl::CreateAppNotificationSyncComponents(
     ProfileSyncService* profile_sync_service,
     browser_sync::UnrecoverableErrorHandler* error_handler) {
   base::WeakPtr<SyncableService> notif_sync_service =