sync: rename ProfileSyncFactory to ProfileSyncComponentsFactory.

sync: rename ProfileSyncFactory to ProfileSyncComponentsFactory.

Makes way for upcoming ProfileSyncServiceFactory.  Note combining the two into one was considered, but the PKS pattern is to use a singleton, which is not ideal for ProfileSyncComponentsFactory.

TBR=mirandac@chromium.org

BUG=93922
TEST=compiles


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111113

[tim (not reviewing), 2011-11-21 23:20:02]

Ready for a look now.

[Nicolas Zea, 2011-11-22 00:01:03]

LGTM with nits

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/glue/no...
File chrome/browser/sync/glue/non_frontend_data_type_controller.cc (right):

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/glue/no...
chrome/browser/sync/glue/non_frontend_data_type_controller.cc:281:
NonFrontendDataTypeController::profile_sync_factory() const {
indent

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_components_factory_impl.cc:218:
ProfileSyncComponentsFactoryImpl::CreateAppSyncComponents(
although all the methods in this file match this format, indent by 4 spaces
here?

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_components_factory_mock.cc (right):

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_components_factory_mock.cc:40:
ProfileSyncComponentsFactoryMock::MakeSyncComponents() {
and here

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_password_unittest.cc (right):

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_password_unittest.cc:89:
change_processor);
indent

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_preference_unittest.cc (right):

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_preference_unittest.cc:62:
*change_processor_ptr);
indent

[tim (not reviewing), 2011-11-22 00:38:15]

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/glue/no...
File chrome/browser/sync/glue/non_frontend_data_type_controller.cc (right):

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/glue/no...
chrome/browser/sync/glue/non_frontend_data_type_controller.cc:281:
NonFrontendDataTypeController::profile_sync_factory() const {
On 2011/11/22 00:01:03, nzea wrote:
> indent

Thought I'd seen this elsewhere... guessing you're looking for 4 spaces, so I'll
do that!

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

http://codereview.chromium.org/8596017/diff/13001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_components_factory_impl.cc:218:
ProfileSyncComponentsFactoryImpl::CreateAppSyncComponents(
On 2011/11/22 00:01:03, nzea wrote:
> although all the methods in this file match this format, indent by 4 spaces
> here?

think we'd generally say consistency trumps the rule here :/ I suppose i can
change them all, if you really want to overturn the decision :)

[commit-bot: I haz the power, 2011-11-22 04:44:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/8596017/18001

[commit-bot: I haz the power, 2011-11-22 04:44:46]

Presubmit check for 8596017-18001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/profiles/profile_impl.cc,chrome/browser/profiles/profile_impl.h

Presubmit checks took 6.5s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2011-11-22 05:44:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/8596017/18001

[commit-bot: I haz the power, 2011-11-22 07:49:54]

Change committed as 111113

[Miranda Callahan, 2011-11-22 13:43:31]

On 2011/11/22 07:49:54, I haz the power (commit-bot) wrote:
> Change committed as 111113

LGTM, thanks!