Issue 8596013: Just show the setting level bubble on the default monitor, since ChromeOS only really supports on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8596013: Just show the setting level bubble on the default monitor, since ChromeOS only really supports on... (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)

Modified:
9 years, 1 month ago

Reviewers:
DaveMoore

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Just show the setting level bubble on the default monitor, since ChromeOS only really supports one monitor right now anyway. Code like this will end up living in aura_shell::Shell by the time we end up figuring out how to support multiple monitors. For now, this removes a USE_AURA ifdef/NOTIMPLEMENTED() and some unnecessary complexity for cros. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110764

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -54 lines)			Patch
	M	chrome/browser/chromeos/setting_level_bubble.cc	View		5 chunks	+4 lines, -54 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages