Issue 8596003: Revert 110613 - Implement the status tray/icon API for ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8596003: Revert 110613 - Implement the status tray/icon API for ChromeOS. (Closed)

Created:
9 years, 1 month ago by Hironori Bono

Modified:
9 years, 1 month ago

Reviewers:
Leandro Graciá Gil

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 110613 - Implement the status tray/icon API for ChromeOS. BUG=74970 TEST=status_tray_chromeos_unittest Review URL: http://codereview.chromium.org/8476003 TBR=leandrogracia@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110636

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -465 lines)			Patch
M	chrome/browser/chromeos/frame/browser_view.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/frame/browser_view.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
D	chrome/browser/ui/views/status_icons/status_icon_chromeos.h	View	1 chunk	+0 lines, -88 lines	0 comments	Download
D	chrome/browser/ui/views/status_icons/status_icon_chromeos.cc	View	1 chunk	+0 lines, -203 lines	0 comments	Download
D	chrome/browser/ui/views/status_icons/status_tray_chromeos.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	chrome/browser/ui/views/status_icons/status_tray_chromeos.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	chrome/browser/ui/views/status_icons/status_tray_chromeos_browsertest.cc	View	1 chunk	+0 lines, -78 lines	0 comments	Download
M	chrome/browser/ui/views/status_icons/status_tray_linux.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

9 years, 1 month ago (2011-11-18 02:09:53 UTC) #2

Greetings,

Unfortunately, I have reverted your change because it broke the "Linux ChromeOS
Aura" bot as shown in
<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20A...>.
I would recommend to run your next change with a 'linux_chromeos_aura' trybot.

Regards,

Hironori Bono

Expand Messages | Collapse Messages