Issue 8595014: Update breakpad to rev: 886.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8595014: Update breakpad to rev: 886. (Closed)

Created:
9 years, 1 month ago by qsr

Modified:
9 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update breakpad to rev: 886. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110931

Patch Set 2 : Update type name. #

Patch Set 4 : Remove whitespace #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	breakpad/breakpad.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/crash_service/crash_service.h	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/tools/crash_service/crash_service.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

qsr

Updating breakpad version -> The fail on Windows for tries is due to flaky tests.

9 years, 1 month ago (2011-11-21 13:42:51 UTC) #1

Mark Mentovai

LGTM http://codereview.chromium.org/8595014/diff/6001/chrome/tools/crash_service/crash_service.h File chrome/tools/crash_service/crash_service.h (right): http://codereview.chromium.org/8595014/diff/6001/chrome/tools/crash_service/crash_service.h#newcode23 chrome/tools/crash_service/crash_service.h:23: Extra blank line not necessary.

9 years, 1 month ago (2011-11-21 13:49:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/8595014/8003

9 years, 1 month ago (2011-11-21 13:51:11 UTC) #3

Change committed as 110931