Issue 8595008: Remove more superfluous write barriers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8595008: Remove more superfluous write barriers. (Closed)

Created:
9 years, 1 month ago by Erik Corry

Modified:
9 years, 1 month ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Remove more superfluous write barriers. Committed: http://code.google.com/p/v8/source/detail?r=10032

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -11 lines)			Patch
M	src/objects.cc	View	2 chunks	+3 lines, -3 lines	2 comments	Download
M	src/runtime.cc	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	src/spaces.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/8595008/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8595008/diff/1/src/objects.cc#newcode5458 src/objects.cc:5458: result->set(kContentArrayIndex, array, SKIP_WRITE_BARRIER); Do we know that result ...

9 years, 1 month ago (2011-11-18 12:26:28 UTC) #2

Erik Corry

9 years, 1 month ago (2011-11-18 13:42:24 UTC) #3

http://codereview.chromium.org/8595008/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/8595008/diff/1/src/objects.cc#newcode5458
src/objects.cc:5458: result->set(kContentArrayIndex, array, SKIP_WRITE_BARRIER);
On 2011/11/18 12:26:28, Lasse Reichstein wrote:
> Do we know that result is in NewSpace? What if it's really big and goes to
> LOSpace? 
> At least make some asserts to ensure that result really, really only can be in
> NewSpace.
> Or comments, if it's obvious when you know it.

I reverted this part of the change.

Expand Messages | Collapse Messages