Have panels respond to changes in work area on Linux.

ui/base/x/active_window_watcher_x.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include <X11/Xlib.h>
 #include <gdk/gdk.h>
 #include <gdk/gdkx.h>
 
 #include "ui/base/x/active_window_watcher_x.h"

[sky, 2011/11/18 17:54:22]

This include should be first, then system includes.

[prasadt, 2011/11/18 22:31:42]

Done.

 
+#include "ui/base/x/root_window_property_watcher_x.h"
+#include "ui/base/x/x11_util.h"
+
 namespace ui {
 
-static Atom g_net_active_window_atom = None;
+static const char* kNetActiveWindow = "_NET_ACTIVE_WINDOW";
 
 // static
 ActiveWindowWatcherX* ActiveWindowWatcherX::GetInstance() {
   return Singleton<ActiveWindowWatcherX>::get();
 }
 
 // static
 void ActiveWindowWatcherX::AddObserver(Observer* observer) {
+  // Ensure that RootWindowPropertyWatcherX exists.
+  RootWindowPropertyWatcherX::GetInstance();
   GetInstance()->observers_.AddObserver(observer);
 }
 
 // static
 void ActiveWindowWatcherX::RemoveObserver(Observer* observer) {
   GetInstance()->observers_.RemoveObserver(observer);
 }
 
 // static
+Atom ActiveWindowWatcherX::GetPropertyAtom() {
+  return GetAtomForScreenProperty(kNetActiveWindow);
+}
+
+// static
+void ActiveWindowWatcherX::Notify() {
+  GetInstance()->NotifyActiveWindowChanged();
+}
+
+// static
 bool ActiveWindowWatcherX::WMSupportsActivation() {
   return gdk_x11_screen_supports_net_wm_hint(
       gdk_screen_get_default(),
-      gdk_atom_intern_static_string("_NET_ACTIVE_WINDOW"));
-}
-
-ActiveWindowWatcherX::ActiveWindowWatcherX() {
-  Init();
-}
-
-ActiveWindowWatcherX::~ActiveWindowWatcherX() {
-}
-
-void ActiveWindowWatcherX::Init() {
-  GdkAtom net_active_window =
-      gdk_atom_intern_static_string("_NET_ACTIVE_WINDOW");
-  g_net_active_window_atom = gdk_x11_atom_to_xatom_for_display(
-      gdk_screen_get_display(gdk_screen_get_default()), net_active_window);
-
-  GdkWindow* root = gdk_get_default_root_window();
-
-  // Set up X Event filter to listen for PropertyChange X events.  These events
-  // tell us when the active window changes.
-  // Don't use XSelectInput directly here, as gdk internally seems to cache the
-  // mask and reapply XSelectInput after this, resetting any mask we set here.
-  gdk_window_set_events(root,
-                        static_cast<GdkEventMask>(gdk_window_get_events(root) |
-                                                  GDK_PROPERTY_CHANGE_MASK));
-  gdk_window_add_filter(NULL, &ActiveWindowWatcherX::OnWindowXEventThunk, this);
+      gdk_atom_intern_static_string(kNetActiveWindow));
 }
 
 void ActiveWindowWatcherX::NotifyActiveWindowChanged() {
   // We don't use gdk_screen_get_active_window() because it caches
   // whether or not the window manager supports _NET_ACTIVE_WINDOW.
   // This causes problems at startup for chromiumos.
   Atom type = None;
   int format = 0;  // size in bits of each item in 'property'
   long unsigned int num_items = 0, remaining_bytes = 0;
   unsigned char* property = NULL;
 
   XGetWindowProperty(gdk_x11_get_default_xdisplay(),
                      GDK_WINDOW_XID(gdk_get_default_root_window()),
-                     g_net_active_window_atom,
+                     GetAtomForScreenProperty(kNetActiveWindow),
                      0,      // offset into property data to read
                      1,      // length to get in 32-bit quantities
                      False,  // deleted
                      AnyPropertyType,
                      &type,
                      &format,
                      &num_items,
                      &remaining_bytes,
                      &property);
 
   // Check that the property was set and contained a single 32-bit item (we
   // don't check that remaining_bytes is 0, though, as XFCE's window manager
   // seems to actually store two values in the property for some unknown
   // reason.)
   if (format == 32 && num_items == 1) {
     int xid = *reinterpret_cast<int*>(property);
     GdkWindow* active_window = gdk_window_lookup(xid);
-    FOR_EACH_OBSERVER(
-        Observer,
-        observers_,
-        ActiveWindowChanged(active_window));
+    FOR_EACH_OBSERVER(Observer, observers_, ActiveWindowChanged(active_window));
   }
   if (property)
     XFree(property);
 }
 
-GdkFilterReturn ActiveWindowWatcherX::OnWindowXEvent(GdkXEvent* xevent,
-                                                     GdkEvent* event) {
-  XEvent* xev = static_cast<XEvent*>(xevent);
-
-  if (xev->xany.type == PropertyNotify &&
-      xev->xproperty.atom == g_net_active_window_atom) {
-    NotifyActiveWindowChanged();
-  }
-
-  return GDK_FILTER_CONTINUE;
-}
-
 }  // namespace ui