Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 8595002: Get rid of gpu_messages.h include in chrome by having the RenderWidgetHostView implementation ask... (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, James Su
Visibility:
Public.

Description

Get rid of gpu_messages.h include in chrome by having the RenderWidgetHostView implementation ask the RenderWidgetHost to ack for the swap buffers GPU message. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110752

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : sync #

Patch Set 5 : fix aura/views build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -70 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 1 2 3 4 3 chunks +5 lines, -15 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 3 chunks +5 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 2 chunks +2 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
(I'm still trying to figure out how to build this, but figured I'd send it ...
9 years, 1 month ago (2011-11-17 23:50:29 UTC) #1
alastairpatrick
It looks okay. You might want to run it by the linux_touch and win_aura bots.
9 years, 1 month ago (2011-11-18 17:41:50 UTC) #2
apatrick_chromium
9 years, 1 month ago (2011-11-21 19:55:02 UTC) #3
Is this ready for review now? Bots look okay. If it's tested on all platforms,
LGTM.

Powered by Google App Engine
This is Rietveld 408576698