Issue 8592006: Update last used profile when deleting profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8592006: Update last used profile when deleting profile (Closed)

Created:
9 years, 1 month ago by sail

Modified:
9 years, 1 month ago

Reviewers:
Robert Sesek, Miranda Callahan

CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update last used profile when deleting profile Deleting a profile can leave the user in a state where their last used profile pionts to a deleted profile. This can lead to crashes when the user opens a new window or uses the menu bar. Fix was to update the last used profile when deleting a profile. BUG=104957 TEST=Created 3 profiles, with just one window open deleted the active profile. Verified that File -> New Window opened a window to the next profile. Verified that Users -> Customize customized the next profile. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111039

Patch Set 1 #

Patch Set 2 : nit #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	chrome/browser/app_controller_mac.mm	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/profiles/profile_manager.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

On 2011/11/21 21:27:16, rsesek wrote: > lgtm LGTM!

9 years, 1 month ago (2011-11-21 21:30:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8592006/1001

9 years, 1 month ago (2011-11-21 21:54:09 UTC) #4

Change committed as 111039

Expand Messages | Collapse Messages