null is an instance of Dynamic (fix issue 443).

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 1381 matching lines @@
   const Bool& bool_false = Bool::ZoneHandle(Bool::False());
 
   // All instances are of a subtype of the Object type.
   const Type& object_type =
       Type::Handle(Isolate::Current()->object_store()->object_type());
   if (type.IsInstantiated() && object_type.IsSubtypeOf(type)) {
     __ PushObject(negate_result ? bool_false : bool_true);
     return;
   }
 
-  // A NULL object always returns false for all types other than Object
-  // (and Null).
   const Immediate raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
-  Label non_null, done;
-  __ cmpl(EAX, raw_null);
-  __ j(NOT_EQUAL, &non_null, Assembler::kNearJump);
-  __ PushObject(negate_result ? bool_true : bool_false);
-  __ jmp(&done, Assembler::kNearJump);
-
-  __ Bind(&non_null);
+  Label done;
   // If type is instantiated and non-parameterized, we can inline code
   // checking whether the tested instance is a Smi.
   if (type.IsInstantiated()) {
+    // A null object is not an instance of any type, except of Object, Dynamic,
+    // and Null type.

[srdjan, 2011/11/21 19:37:08]

It may be simpler to explain this in positive formulation:
"A null type is only an instance of Object, Dynamic or Null type."
Can we ever see a Null type here?

The case for "null is Object" is handled above, isn't it? Maybe add a comment.

[regis, 2011/11/21 19:53:31]

I'll remove the mention of Null type, since it is only a VM internal type that
cannot be seen by the user.

The cases for "null is Object" and for "null is Dynamic" are only handled above
if the other type (Object or Dynamic) is instantiated.

I'll add a comment in my next cl.

+    // We can only inline this null check if the type is instantiated at compile
+    // time, since an uninstantiated type at compile time could be Object or
+    // Dynamic at run time.
+    Label non_null;
+    __ cmpl(EAX, raw_null);
+    __ j(NOT_EQUAL, &non_null, Assembler::kNearJump);
+    __ PushObject(negate_result ? bool_true : bool_false);
+    __ jmp(&done, Assembler::kNearJump);
+
+    __ Bind(&non_null);
+
     const Class& type_class = Class::ZoneHandle(type.type_class());
     const bool requires_type_arguments = type_class.HasTypeArguments();
     // A Smi object cannot be the instance of a parameterized class.
     // A class equality check is only applicable with a dst type of a
     // non-parameterized class or with a raw dst type of a parameterized class.
     if (requires_type_arguments) {
       const TypeArguments& type_arguments =
           TypeArguments::Handle(type.arguments());
       const bool is_raw_type = type_arguments.IsNull() ||
           type_arguments.IsDynamicTypes(type_arguments.Length());
@@ skipping 1328 matching lines @@
                         message_buffer, kMessageBufferSize,
                         format, args);
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, message_buffer);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32