Print Preview: Fixing javascript error occuring in the margins code.

chrome/browser/resources/print_preview/preview_area.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'strict';
 
   /**
    * Creates a PreviewArea object. It represents the area where the preview
    * document is displayed.
@@ skipping 73 matching lines @@
      * The height of the plugin area in percent, excluding any visible
      *     scrollbars.
      * @type {number}
      */
     get heightPercent() {
       var height = this.pdfPlugin_.getHeight();
       var scrollbarHeight = this.pdfPlugin_.getHorizontalScrollbarThickness();
       return (height - scrollbarHeight) / height;
     },
 
+    get pdfPlugin() {
+      return this.pdfPlugin_;
+    },
+
     get pdfLoaded() {
       return this.pdfLoaded_;
     },
 
     set pdfLoaded(pdfLoaded) {
       this.pdfLoaded_ = pdfLoaded;
     },
 
     /**
      * Queries the plugin for the location of the most visible page and updates
      * |this.pageLocationNormalized|.
      */
     update: function() {
       if (!this.pdfLoaded_)

[kmadhusu, 2011/11/21 19:20:22]

Reuse the getter function.

[dpapad, 2011/11/22 02:05:10]

Why use the getter within this class when the variable can be accessed directly?
Getters are for clients of that class.

[kmadhusu, 2011/11/22 02:32:26]

Ofcourse it is not strict rule, it is just my opinion. It is a nit.

         return;
       var pluginLocation =
           this.pdfPlugin_.getPageLocationNormalized().split(';');
       this.pageLocationNormalized = new print_preview.Rect(
           parseFloat(pluginLocation[0]),
           parseFloat(pluginLocation[1]),
           parseFloat(pluginLocation[2]),
           parseFloat(pluginLocation[3]));
     },
 
     /**
      * Resets the state variables of |this|.
      */
     resetState: function() {
       if (this.pdfPlugin_) {

[kmadhusu, 2011/11/21 19:20:22]

same here

[dpapad, 2011/11/22 02:05:10]

See previous comment.

         this.zoomLevel_ = this.pdfPlugin_.getZoomLevel();
         this.pageOffset_ = {
             x: this.pdfPlugin_.pageXOffset(),
             y: this.pdfPlugin_.pageYOffset()
         };
       }
       this.pdfLoaded_ = false;
     },
 
     /**
@@ skipping 105 matching lines @@
       if (cr.isMac)
         $('open-preview-app-throbber').hidden = true;
       this.displayErrorMessageAndNotify(errorMessage);
     }
   };
 
   return {
     PreviewArea: PreviewArea,
   };
 });