Issue 8592001: Valgrind: Fix a leak in ContentSettingsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8592001: Valgrind: Fix a leak in ContentSettingsProvider. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
Bernhard Bauer, Lei Zhang, markusheintz_, markusheintz

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Valgrind: Fix a leak in ContentSettingsProvider. If the call to SetWebsiteSetting() fails, the value is still owned by the caller and must be deleted. BUG=none TEST=none R=bauerb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110594

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	chrome/browser/content_settings/content_settings_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/content_settings/host_content_settings_map.cc	View		1 chunk	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM for the purposes of fixing the leak. Perhaps the callee should be responsible for ...

9 years, 1 month ago (2011-11-17 22:21:20 UTC) #3

markusheintz

9 years, 1 month ago (2011-11-18 16:26:03 UTC) #4

Thanks a lot for fixing the leak!

I did some investigation to way I didn't catch this leak. It turned out
that when I ran valgrind I set the gtest_filter to tight. Sorry next time
I'll use the valgrind try bot.

However I created CL http://codereview.chromium.org/8528031 to follow up on
this. This CL also catches one more leak.

On Thu, Nov 17, 2011 at 11:21 PM, <thestig@chromium.org> wrote:

> LGTM for the purposes of fixing the leak.
>
> Perhaps the callee should be responsible for taking ownership and freeing
> |value|, even in the case of failure?
>
>
http://codereview.chromium.**org/8592001/<http://codereview.chromium.org/8592...
>

-- 
Markus

Expand Messages | Collapse Messages