Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: net/http/http_pipelined_stream.cc

Issue 8591037: Implement Drain() on HttpPipelinedStream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More tests Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_pipelined_stream.cc
diff --git a/net/http/http_pipelined_stream.cc b/net/http/http_pipelined_stream.cc
index 6b844a6210ddae7eb0f3ca8d16c29fe9d6c290af..bec950e8b123aba3d8d7c4cfd715cdd2ddd0c170 100644
--- a/net/http/http_pipelined_stream.cc
+++ b/net/http/http_pipelined_stream.cc
@@ -10,6 +10,7 @@
#include "net/http/http_pipelined_connection_impl.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_request_info.h"
+#include "net/http/http_response_info.h"
mmenke 2011/11/28 18:39:10 nit: Is this needed? We don't seem to do more th
James Simonsen 2011/11/29 23:57:28 Done.
#include "net/http/http_util.h"
namespace net {
@@ -118,11 +119,8 @@ void HttpPipelinedStream::LogNumRttVsBytesMetrics() const {
// TODO(simonjam): I don't want to copy & paste this from http_basic_stream.
}
-void HttpPipelinedStream::Drain(HttpNetworkSession*) {
- // On errors, we already evict everything from the pipeline and close it.
- // TODO(simonjam): Consider trying to drain the pipeline in the same way that
- // HttpBasicStream does.
- delete this;
+void HttpPipelinedStream::Drain(HttpNetworkSession* session) {
+ pipeline_->Drain(this, session);
}
const SSLConfig& HttpPipelinedStream::used_ssl_config() const {

Powered by Google App Engine
This is Rietveld 408576698