Issue 8591035: Clean up disable_nacl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8591035: Clean up disable_nacl (Closed)

Created:
9 years, 1 month ago by Roland McGrath

Modified:
9 years, 1 month ago

Reviewers:
Mark Seaborn

CC:
chromium-reviews, native-client-reviews_googlegroups.com, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean up disable_nacl The status quo is to compile in a bunch of dead code under disable_nacl. It's then littered with conditionals to avoid using things not linked in. That's just silly. When NaCl is disabled, we should not compile any of it in. BUG= none TEST= builds with and without GYP_DEFINES=disable_nacl=1 R=mseaborn@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110712

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -22 lines)			Patch
M	chrome/browser/nacl_host/nacl_process_host.cc	View	6 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_message_filter.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_message_filter.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/renderer/chrome_ppapi_interfaces.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Much nicer now, thanks!

Expand Messages | Collapse Messages