Move clipboard-related webkit_glue embedder functions into a ClipboardClient interface.

content/renderer/renderer_webkitplatformsupport_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDERER_WEBKITPLATFORMSUPPORT_IMPL_H_
 #define CONTENT_RENDERER_RENDERER_WEBKITPLATFORMSUPPORT_IMPL_H_
 #pragma once
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/platform_file.h"
 #include "content/common/content_export.h"
 #include "webkit/glue/webkitplatformsupport_impl.h"
 
+class RendererClipboardClient;
 class WebSharedWorkerRepositoryImpl;
 class WebFileSystemImpl;
 
 namespace IPC {
 class SyncMessage;
 }
 
 namespace webkit_glue {
 class WebClipboardImpl;
 }
@@ skipping 63 matching lines @@
   virtual WebKit::WebBlobRegistry* blobRegistry();
 
   virtual WebKit::WebString userAgent(const WebKit::WebURL& url);
 
  private:
   bool CheckPreparsedJsCachingEnabled() const;
 
   // Helper function to send synchronous message from any thread.
   static bool SendSyncMessageFromAnyThread(IPC::SyncMessage* msg);
 
+  scoped_ptr<RendererClipboardClient> clipboard_client_;

[tony, 2011/11/21 22:42:54]

Should we just stack allocate this?

[piman, 2011/11/22 00:27:20]

I'm not sure I understand what you're suggesting here... When do you suggest we
allocate it on the stack?

[tony, 2011/11/22 00:46:23]

Could this be RendererClipboardClient clipboard_client_ and in the initializer
list:

 clipboard_(new webkit_glue::WebClipboardImpl(&clipboard_client_)),

   scoped_ptr<webkit_glue::WebClipboardImpl> clipboard_;
 
   class FileUtilities;
   scoped_ptr<FileUtilities> file_utilities_;
 
   class MimeRegistry;
   scoped_ptr<MimeRegistry> mime_registry_;
 
   class SandboxSupport;
   scoped_ptr<SandboxSupport> sandbox_support_;
 
   // This counter keeps track of the number of times sudden termination is
   // enabled or disabled. It starts at 0 (enabled) and for every disable
   // increments by 1, for every enable decrements by 1. When it reaches 0,
   // we tell the browser to enable fast termination.
   int sudden_termination_disables_;
 
   // Implementation of the WebSharedWorkerRepository APIs (provides an interface
   // to WorkerService on the browser thread.
   scoped_ptr<WebSharedWorkerRepositoryImpl> shared_worker_repository_;
 
   scoped_ptr<WebKit::WebIDBFactory> web_idb_factory_;
 
   scoped_ptr<WebFileSystemImpl> web_file_system_;
 
   scoped_ptr<WebKit::WebBlobRegistry> blob_registry_;
 };
 
 #endif  // CONTENT_RENDERER_RENDERER_WEBKITPLATFORMSUPPORT_IMPL_H_