Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: media/audio/audio_util.cc

Issue 8591028: Change the way we are sending audio data to driver when using WaveOut API. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/win/waveout_output_win.h » ('j') | media/audio/win/waveout_output_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_util.cc
===================================================================
--- media/audio/audio_util.cc (revision 111710)
+++ media/audio/audio_util.cc (working copy)
@@ -293,6 +293,11 @@
#if defined(OS_MACOSX)
return 128;
#elif defined(OS_WIN)
+ if (base::win::GetVersion() <= base::win::VERSION_XP) {
henrika (OOO until Aug 14) 2011/11/29 12:20:42 This will most likely not work! It is correct tha
Raymond Toy (Google) 2011/11/29 18:13:57 This will mostly likely need to be set to 2048 aga
+ // Fall back to Windows Wave implementation on Windows XP or lower
+ // and assume 48kHz as default sample rate.
+ return 480;
Raymond Toy (Google) 2011/11/29 18:45:29 I tested this on my Windows 7 machine by adjusting
enal 2011/11/29 18:57:44 2048 does not help with either new or old implemen
Raymond Toy (Google) 2011/11/29 20:01:29 This seems not right. How did you test this? 204
enal 2011/11/29 21:02:45 I figured out what my problem was when testing on
+ }
// This call must be done on a COM thread configured as MTA.
// TODO(tommi): http://code.google.com/p/chromium/issues/detail?id=103835.
int mixing_sample_rate =
« no previous file with comments | « no previous file | media/audio/win/waveout_output_win.h » ('j') | media/audio/win/waveout_output_win.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698