Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: client/dom/frog/frog_dom.js

Issue 8591026: Roll DOM APIs forward on IDL & update Frog DOM (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Switch frog to pull dart/client/dom/frog/frog_dom.dart. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/frog/frog_dom.dart ('k') | client/dom/frog_dom.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/frog/frog_dom.js
diff --git a/frog/lib/dom/frog_dom.js b/client/dom/frog/frog_dom.js
similarity index 50%
rename from frog/lib/dom/frog_dom.js
rename to client/dom/frog/frog_dom.js
index a794918b8255a2ce3fb5317f58398462db94052c..45984d4a0f35c3ec9f5d02e4be71a93e63dff3c7 100644
--- a/frog/lib/dom/frog_dom.js
+++ b/client/dom/frog/frog_dom.js
@@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// TODO(jmesserly): we need to find a way to avoid conflicts with other
-// generated "typeName" fields. Ideally we wouldn't be patching 'Object' here.
-Object.prototype.get$typeName = Object.prototype.$typeNameOf;
+// TODO(vsm): Don't monkey patch Object and make this work on
+// non-chrome browsers.
+Object.prototype.get$typeName = function() {
+ return this.constructor.name;
Siggi Cherem (dart-lang) 2011/11/18 00:15:45 is this part of the change on purpose?
vsm 2011/11/18 00:22:01 No - thanks for the catch. Will fix and reupload.
+}
« no previous file with comments | « client/dom/frog/frog_dom.dart ('k') | client/dom/frog_dom.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698