Correct the order of destruction of ProfileImplIOData and ExtensionProcessManager. This was causi...

chrome/browser/profiles/profile_impl.h

Index: chrome/browser/profiles/profile_impl.h
===================================================================
--- chrome/browser/profiles/profile_impl.h	(revision 110070)
+++ chrome/browser/profiles/profile_impl.h	(working copy)
@@ -189,6 +189,13 @@
 
   FilePath path_;
   FilePath base_cache_path_;
+
+  // !!! BIG HONKING WARNING !!!
+  //  The order of the members below is important. Do not change it unless
+  //  you know what you're doing. Also, if adding a new member here make sure
+  //  that the declaration occurs AFTER things it depends on as destruction
+  //  happens in reverse order of declaration.
+
   scoped_ptr<ExtensionPrefValueMap> extension_pref_value_map_;
   // Keep |prefs_| on top for destruction order because |extension_prefs_|,
   // |net_pref_observer_|, |web_resource_service_|, and |io_data_| store
@@ -202,6 +209,13 @@
   scoped_ptr<ExtensionPrefs> extension_prefs_;
   scoped_ptr<ExtensionService> extension_service_;
   scoped_refptr<UserScriptMaster> user_script_master_;
+
+  // io_data_ needs to outlive extension_process_manager_.

[willchan no longer on Chromium, 2011/11/17 20:11:32]

|io_data_| needs to outlive a lot of things. Rather than enumerate them here,
I'd rather we do the vice versa. At |extension_process_manager_| note that it
must be destroyed after |io_data|.

[robertshield, 2011/11/17 21:00:43]

Done.

+  // While the extension_process_manager_ still lives, we handle incoming
+  // resource requests from extension processes and those require access
+  // to the ResourceContext owned by io_data_.
+  ProfileImplIOData::Handle io_data_;
+
   scoped_refptr<ExtensionDevToolsManager> extension_devtools_manager_;
   // extension_info_map_ needs to outlive extension_process_manager_.
   scoped_refptr<ExtensionInfoMap> extension_info_map_;
@@ -222,8 +236,6 @@
   scoped_ptr<ProfileSyncFactory> profile_sync_factory_;
   scoped_ptr<ProfileSyncService> sync_service_;
 
-  ProfileImplIOData::Handle io_data_;
-
   scoped_ptr<SSLConfigServiceManager> ssl_config_service_manager_;
 
   scoped_refptr<HostContentSettingsMap> host_content_settings_map_;