Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: chrome/browser/ui/browser_close_browsertest.cc

Issue 8591024: Correct the order of destruction of ProfileImplIOData and ExtensionProcessManager. This was causi... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/profiles/profile_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/logging.h" 6 #include "base/logging.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/stringprintf.h" 8 #include "base/stringprintf.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/download/download_service.h" 10 #include "chrome/browser/download/download_service.h"
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 result += base::StringPrintf( 495 result += base::StringPrintf(
496 "%s (%d downloads) warning", 496 "%s (%d downloads) warning",
497 (type == Browser::DOWNLOAD_CLOSE_BROWSER_SHUTDOWN ? "Browser shutdown" : 497 (type == Browser::DOWNLOAD_CLOSE_BROWSER_SHUTDOWN ? "Browser shutdown" :
498 type == Browser::DOWNLOAD_CLOSE_LAST_WINDOW_IN_INCOGNITO_PROFILE ? 498 type == Browser::DOWNLOAD_CLOSE_LAST_WINDOW_IN_INCOGNITO_PROFILE ?
499 "Incognito close" : "Unknown"), 499 "Incognito close" : "Unknown"),
500 num_blocking); 500 num_blocking);
501 } 501 }
502 return result; 502 return result;
503 } 503 }
504 504
505 // The following test is split into three chunks to reduce the chance 505 // The following test is split into six chunks to reduce the chance
506 // of hitting the 25s timeout. 506 // of hitting the 25s timeout.
507 507
508 IN_PROC_BROWSER_TEST_F(BrowserCloseTest, DownloadsCloseCheck_0) { 508 IN_PROC_BROWSER_TEST_F(BrowserCloseTest, DownloadsCloseCheck_0) {
509 ASSERT_TRUE(SetupForDownloadCloseCheck()); 509 ASSERT_TRUE(SetupForDownloadCloseCheck());
510 for (size_t i = 0; i < arraysize(download_close_check_cases) / 6; ++i) { 510 for (size_t i = 0; i < arraysize(download_close_check_cases) / 6; ++i) {
511 ExecuteDownloadCloseCheckCase(i); 511 ExecuteDownloadCloseCheckCase(i);
512 } 512 }
513 } 513 }
514 514
515 IN_PROC_BROWSER_TEST_F(BrowserCloseTest, DownloadsCloseCheck_1) { 515 IN_PROC_BROWSER_TEST_F(BrowserCloseTest, DownloadsCloseCheck_1) {
(...skipping 28 matching lines...) Expand all
544 } 544 }
545 } 545 }
546 546
547 IN_PROC_BROWSER_TEST_F(BrowserCloseTest, DownloadsCloseCheck_5) { 547 IN_PROC_BROWSER_TEST_F(BrowserCloseTest, DownloadsCloseCheck_5) {
548 ASSERT_TRUE(SetupForDownloadCloseCheck()); 548 ASSERT_TRUE(SetupForDownloadCloseCheck());
549 for (size_t i = 5 * arraysize(download_close_check_cases) / 6; 549 for (size_t i = 5 * arraysize(download_close_check_cases) / 6;
550 i < 6 * arraysize(download_close_check_cases) / 6; ++i) { 550 i < 6 * arraysize(download_close_check_cases) / 6; ++i) {
551 ExecuteDownloadCloseCheckCase(i); 551 ExecuteDownloadCloseCheckCase(i);
552 } 552 }
553 } 553 }
OLDNEW
« no previous file with comments | « chrome/browser/profiles/profile_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698