Issue 8591009: ChromeFrame: Convert TaskMarshallerThroughMessageQueue to new Callback system.

Issue 8591009: ChromeFrame: Convert TaskMarshallerThroughMessageQueue to new Callback system. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
csilv, ananta, willchan no longer on Chromium, stoyan

CC:
chromium-reviews, robertshield, amit, sadrul, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ChromeFrame: Convert TaskMarshallerThroughMessageQueue to new Callback system. BUG=none TEST=none R=willchan@chromium.org,stoyan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110595

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -131 lines)			Patch
M	base/message_loop.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	base/pending_task.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/pending_task.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/threading/worker_pool_posix.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome_frame/cfproxy_private.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome_frame/cfproxy_proxy.cc	View	1	4 chunks	+19 lines, -14 lines	0 comments	Download
M	chrome_frame/external_tab.cc	View	1	6 chunks	+38 lines, -31 lines	0 comments	Download
M	chrome_frame/task_marshaller.h	View	1	3 chunks	+16 lines, -17 lines	0 comments	Download
M	chrome_frame/task_marshaller.cc	View	1	5 chunks	+35 lines, -59 lines	0 comments	Download

Total messages: 6 (0 generated)

csilv

On 2011/11/17 18:58:27, James Hawkins wrote: > Chris, can you review the base::Bind changes? base:Bind ...

9 years, 1 month ago (2011-11-17 19:14:20 UTC) #4

James Hawkins

On 2011/11/17 19:14:20, csilv wrote: > On 2011/11/17 18:58:27, James Hawkins wrote: > > Chris, ...

9 years, 1 month ago (2011-11-17 19:22:12 UTC) #5

LGTM