Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 8591004: Don't build a bunch of stuff on Aura, rather than ifdefing out code in it. (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, jam, kkania, robertshield, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Don't build a bunch of stuff on Aura, rather than ifdefing out code in it. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110567

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -38 lines) Patch
M chrome/browser/automation/chrome_frame_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/ui_controls_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_mode_manager_gtk.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_plugin_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_plugin_message_filter.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/plugin_download_helper.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/plugin_download_helper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/plugin_installer_infobar_delegate.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/plugin_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 7 chunks +25 lines, -17 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
9 years, 1 month ago (2011-11-17 00:37:56 UTC) #1
sky
9 years, 1 month ago (2011-11-17 04:42:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698