Issue 8591002: MIPS: Re-work DoModI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8591002: MIPS: Re-work DoModI. (Closed)

Created:
9 years, 1 month ago by kisg

Modified:
9 years, 1 month ago

Reviewers:
Paul Lind, danno

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Re-work DoModI. Changes: -separated the two code-paths (constant power of 2 divisor similar to ARM and everything else) -replaced a bailout condition with faster handling (negative modulo result) -removed a possibly useless mov instruction from one path -replaced the IsConstantOperand condition with the more meaningful HasPowerOf2Divisor (although in this specific case they're equivalent) BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10016

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -40 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+35 lines, -40 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages