Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble.h

Issue 8590047: Rebase ExtensionInstalledBubble on the new views bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase ExtensionInstalledBubble on the new views bubble. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_installed_bubble.h
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble.h b/chrome/browser/ui/views/extensions/extension_installed_bubble.h
index f269ed154360d10199fb7547d2da896d728448d2..acfffef646eb21f8f278167c9412da4727fd6e4b 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble.h
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble.h
@@ -7,10 +7,10 @@
#pragma once
#include "base/memory/ref_counted.h"
-#include "chrome/browser/ui/views/bubble/bubble.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "third_party/skia/include/core/SkBitmap.h"
+#include "views/bubble/bubble_delegate.h"
class Browser;
class Extension;
@@ -30,7 +30,7 @@ class SkBitmap;
//
// ExtensionInstallBubble manages its own lifetime.
class ExtensionInstalledBubble
- : public BubbleDelegate,
+ : public views::BubbleDelegateView,
public content::NotificationObserver,
public base::RefCountedThreadSafe<ExtensionInstalledBubble> {
public:
@@ -54,8 +54,9 @@ class ExtensionInstalledBubble
friend class base::RefCountedThreadSafe<ExtensionInstalledBubble>;
// Private ctor. Registers a listener for EXTENSION_LOADED.
- ExtensionInstalledBubble(
- const Extension* extension, Browser *browser, const SkBitmap& icon);
+ ExtensionInstalledBubble(const Extension* extension,
+ Browser *browser,
+ const SkBitmap& icon);
virtual ~ExtensionInstalledBubble();
@@ -67,16 +68,17 @@ class ExtensionInstalledBubble
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
- // BubbleDelegate
- virtual void BubbleClosing(Bubble* bubble, bool closed_by_escape) OVERRIDE;
- virtual bool CloseOnEscape() OVERRIDE;
- virtual bool FadeInOnShow() OVERRIDE;
+ // views::WidgetDelegate
+ virtual void WindowClosing() OVERRIDE;
+
+ // views::BubbleDelegate
+ virtual gfx::Point GetAnchorPoint() OVERRIDE;
+ virtual views::BubbleBorder::ArrowLocation GetArrowLocation() const OVERRIDE;
const Extension* extension_;
Browser* browser_;
SkBitmap icon_;
content::NotificationRegistrar registrar_;
- InstalledBubbleContent* bubble_content_;
BubbleType type_;
// How many times we've deferred due to animations being in progress.
« no previous file with comments | « chrome/browser/ui/views/browser_actions_container.h ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698