Tweak for about:net-internals timeline view: make checkbox labels clickable.

Tweak for about:net-internals timeline view: make checkbox labels clickable.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110833

[mmenke, 2011-11-18 01:08:40]

LGTM.  Since you're using the span, that means the colored squares aren't
clickable, right?

[eroman, 2011-11-18 01:21:24]

correct, the squares are not clickable.

[commit-bot: I haz the power, 2011-11-18 01:57:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/8590046/1

[eroman, 2011-11-18 02:31:59]

Apologies, could you take another look?

I have a better solution now, which makes the colored boxes clickable too.

(I was confused on how label works, but seems to be working how I want).

[eroman, 2011-11-18 02:40:58]

http://codereview.chromium.org/8590046/diff/5001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/timeline_view.html (right):

http://codereview.chromium.org/8590046/diff/5001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/timeline_view.html:8: </input></li>
Actually these terminal <input> tags are a little funky, I am pretty sure we can
remove them.

[mmenke, 2011-11-18 04:05:43]

LGTM.  I wasn't familiar with the label tag.  Reading about it, looks pretty
nifty.

http://codereview.chromium.org/8590046/diff/5001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/timeline_view.html (right):

http://codereview.chromium.org/8590046/diff/5001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/timeline_view.html:8: </input></li>
On 2011/11/18 02:40:58, eroman wrote:
> Actually these terminal <input> tags are a little funky, I am pretty sure we
can
> remove them.

You're right.  Feel free to do so.

[commit-bot: I haz the power, 2011-11-19 01:42:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/8590046/5001

[commit-bot: I haz the power, 2011-11-19 03:08:03]

Try job failure for 8590046-5001 (retry) (retry) on linux_rel for step
"ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-19 03:12:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/8590046/5001

[commit-bot: I haz the power, 2011-11-19 06:09:40]

Change committed as 110833