Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 8590041: sync: remove includes from ProfileSyncFactory + add to AutofillDataTypeController (Closed)

Created:
9 years, 1 month ago by tim (not reviewing)
Modified:
8 years, 11 months ago
CC:
chromium-reviews, GeorgeY, ncarter (slow), akalin, Raghu Simha, dyu1, Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

sync: remove includes from ProfileSyncFactory + add to AutofillDataTypeController Probably the awesomest patch evar BUG=none TEST=compiles! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tim (not reviewing)
9 years, 1 month ago (2011-11-17 21:25:56 UTC) #1
Nicolas Zea
LGTM!
9 years, 1 month ago (2011-11-17 21:28:44 UTC) #2
Nicolas Zea
LGTM!
9 years, 1 month ago (2011-11-17 21:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/8590041/1
9 years, 1 month ago (2011-11-17 21:33:16 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 22:53:12 UTC) #5
Change committed as 110586

Powered by Google App Engine
This is Rietveld 408576698