Add buttons to clear the cache and flush socket pools

Add buttons to clear the cache and flush socket
pools to net-internals events view.  This can make
reproducing some issues much less painful.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110605

[mmenke, 2011-11-17 20:34:11]

Ran into a bug with server redirects that needed a clear cache and no open idle
sockets to a server to reproduce.  The buttons this CL adds would have made
things a little simpler.

[eroman, 2011-11-17 20:46:35]

lgtm

http://codereview.chromium.org/8590037/diff/5001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/events_view.html (right):

http://codereview.chromium.org/8590037/diff/5001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/events_view.html:32: <input type=button
value="Clear cache" id=events-view-clear-cache class=warningText />
I'm not convinced that the Events tab is the right place for these buttons. The
"Clear cache" for instance should probably go on the cache tab...

But if you think this helps, then I won't block it.

[mmenke, 2011-11-17 20:54:48]

"Change to DNS tab -> Clear DNS -> Change to cache tab -> clear cache -> change
to sockets tab -> flush -> change to events tab -> delete all" is just too much
work to get a clean state when trying to reproduce an issue, in my opinion.

I'm happy to also put it on the cache tab, but having everything in a
centralized location is so much more convenient.  Click 3 buttons right next to
each other, rather than going through 4 pages, locating and pressing a button on
each page.

If you have another suggestion on how to simplify things, I'm open to ideas.

On 2011/11/17 20:46:35, eroman wrote:
> lgtm
> 
>
http://codereview.chromium.org/8590037/diff/5001/chrome/browser/resources/net...
> File chrome/browser/resources/net_internals/events_view.html (right):
> 
>
http://codereview.chromium.org/8590037/diff/5001/chrome/browser/resources/net...
> chrome/browser/resources/net_internals/events_view.html:32: <input type=button
> value="Clear cache" id=events-view-clear-cache class=warningText />
> I'm not convinced that the Events tab is the right place for these buttons.
The
> "Clear cache" for instance should probably go on the cache tab...
> 
> But if you think this helps, then I won't block it.

[mmenke, 2011-11-17 20:57:40]

One option would be to just put buttons on the right of their "tabs" on the bar
on the right.  We could just label them 'clear' (And 'flush' for sockets). 
Might be a little ugly, but wouldn't take up too much space.

On 2011/11/17 20:54:48, Matt Menke wrote:
> "Change to DNS tab -> Clear DNS -> Change to cache tab -> clear cache ->
change
> to sockets tab -> flush -> change to events tab -> delete all" is just too
much
> work to get a clean state when trying to reproduce an issue, in my opinion.
> 
> I'm happy to also put it on the cache tab, but having everything in a
> centralized location is so much more convenient.  Click 3 buttons right next
to
> each other, rather than going through 4 pages, locating and pressing a button
on
> each page.
> 
> If you have another suggestion on how to simplify things, I'm open to ideas.
> 
> On 2011/11/17 20:46:35, eroman wrote:
> > lgtm
> > 
> >
>
http://codereview.chromium.org/8590037/diff/5001/chrome/browser/resources/net...
> > File chrome/browser/resources/net_internals/events_view.html (right):
> > 
> >
>
http://codereview.chromium.org/8590037/diff/5001/chrome/browser/resources/net...
> > chrome/browser/resources/net_internals/events_view.html:32: <input
type=button
> > value="Clear cache" id=events-view-clear-cache class=warningText />
> > I'm not convinced that the Events tab is the right place for these buttons.
> The
> > "Clear cache" for instance should probably go on the cache tab...
> > 
> > But if you think this helps, then I won't block it.

[eroman, 2011-11-17 22:01:14]

Yeah, I can see how that is annoying :(
On events tab is fine for now.

Another idea could be to put it in the top bar (i.e. the region which is
currently a red bar).

Conceptually we could put common actions on the right of the red bar, since we
have lots of empty space when in recording mode.

If it gets cramped, we could maybe hide them by default, but then if you click
some button they show up there for easy access.



I am not sure I understand what you mean by the "right bar". Did you mean the
left bar where the tab handles are shown? That sounds reasonable too, we could
list certain common actions right beside the tab switcher, but that might become
a little spread out as we add stuff.

[mmenke, 2011-11-17 22:22:27]

Yea, I meant the left bar.  I...ummm...just meant my monitor's right, which
would be my left, of course.  Was thinking we could have something like:

Events [Clear]
DNS [Clear]
Sockets [Flush]
SPDY [Flush]
HTTP Cache [Clear]
...
Prerender [Flush]
etc.

Would make the fit for everything else a little tighter, though, as you say.

I think putting stuff at the top would also be reasonable.  I'll land this
as-is, but I'll plan to play with placement in my copious free time.


On 2011/11/17 22:01:14, eroman wrote:
> Yeah, I can see how that is annoying :(
> On events tab is fine for now.
> 
> Another idea could be to put it in the top bar (i.e. the region which is
> currently a red bar).
> 
> Conceptually we could put common actions on the right of the red bar, since we
> have lots of empty space when in recording mode.
> 
> If it gets cramped, we could maybe hide them by default, but then if you click
> some button they show up there for easy access.
> 
> 
> 
> I am not sure I understand what you mean by the "right bar". Did you mean the
> left bar where the tab handles are shown? That sounds reasonable too, we could
> list certain common actions right beside the tab switcher, but that might
become
> a little spread out as we add stuff.

[commit-bot: I haz the power, 2011-11-17 22:29:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/8590037/5001

[eroman, 2011-11-17 22:32:58]

:-)

<shameless_advertisement>
BTW, if you are ever bored and feel you aren't getting the opportunity to write
enough Javascript code... I've been hacking on a new one (about:profiler), and
your pro-skillz are always welcome! The next interesting feature for that tool
is going to be some sort of snapshotting/diffing ability, to compare runtime
profiles.
</shameless_advertisement>

[commit-bot: I haz the power, 2011-11-17 23:55:44]

Change committed as 110605

[mmenke, 2011-11-18 01:12:39]

That sounds really cool.  I'd love to help, though as the timeline view took a
fair bit longer than I expected, I probably shouldn't spend that much time on
it, until I've made some progress on the captive portals thing.

On 2011/11/17 22:32:58, eroman wrote:
> :-)
> 
> <shameless_advertisement>
> BTW, if you are ever bored and feel you aren't getting the opportunity to
write
> enough Javascript code... I've been hacking on a new one (about:profiler), and
> your pro-skillz are always welcome! The next interesting feature for that tool
> is going to be some sort of snapshotting/diffing ability, to compare runtime
> profiles.
> </shameless_advertisement>