Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 8590031: Added machine names to about:sessions. (Closed)

Created:
9 years, 1 month ago by SteveT
Modified:
9 years, 1 month ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Added machine names to about:sessions. BUG=98836 TEST=Enable Open Tab syncing and sync some open tabs between two clients. Ensure that the about:sessions page displays the machine names under the sessions list. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110514

Patch Set 1 #

Patch Set 2 : Fixed quotation marks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/sessions.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sessions_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
SteveT
PTAL.
9 years, 1 month ago (2011-11-17 15:55:44 UTC) #1
Alexei Svitkine (slow)
lgtm
9 years, 1 month ago (2011-11-17 15:59:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/8590031/2001
9 years, 1 month ago (2011-11-17 16:03:56 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 17:15:08 UTC) #4
Change committed as 110514

Powered by Google App Engine
This is Rietveld 408576698