Index: src/x64/full-codegen-x64.cc |
diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc |
index 2dc765bcbac3c3ac4dd249205aafea906bf627f7..35b902d7aea8539f5de3251b42d5adc9e156decf 100644 |
--- a/src/x64/full-codegen-x64.cc |
+++ b/src/x64/full-codegen-x64.cc |
@@ -1480,10 +1480,9 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
int length = subexprs->length(); |
Handle<FixedArray> constant_elements = expr->constant_elements(); |
ASSERT_EQ(2, constant_elements->length()); |
-#if DEBUG |
ElementsKind constant_elements_kind = |
static_cast<ElementsKind>(Smi::cast(constant_elements->get(0))->value()); |
-#endif |
+ bool has_constant_fast_elements = constant_elements_kind == FAST_ELEMENTS; |
Handle<FixedArrayBase> constant_elements_values( |
FixedArrayBase::cast(constant_elements->get(1))); |
@@ -1491,7 +1490,17 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
__ push(FieldOperand(rbx, JSFunction::kLiteralsOffset)); |
__ Push(Smi::FromInt(expr->literal_index())); |
__ Push(constant_elements); |
- if (expr->depth() > 1) { |
+ Heap* heap = isolate()->heap(); |
+ if (has_constant_fast_elements && |
+ constant_elements_values->map() == heap->fixed_cow_array_map()) { |
+ // If the elements are already FAST_ELEMENTS, the boilerplate cannot |
+ // change, so it's possible to specialize the stub in advance. |
+ __ IncrementCounter(isolate()->counters()->cow_arrays_created_stub(), 1); |
+ FastCloneShallowArrayStub stub( |
+ FastCloneShallowArrayStub::COPY_ON_WRITE_ELEMENTS, |
+ length); |
+ __ CallStub(&stub); |
+ } else if (expr->depth() > 1) { |
__ CallRuntime(Runtime::kCreateArrayLiteral, 3); |
} else if (length > FastCloneShallowArrayStub::kMaximumClonedLength) { |
__ CallRuntime(Runtime::kCreateArrayLiteralShallow, 3); |
@@ -1499,13 +1508,12 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
ASSERT(constant_elements_kind == FAST_ELEMENTS || |
constant_elements_kind == FAST_SMI_ONLY_ELEMENTS || |
FLAG_smi_only_arrays); |
- if (constant_elements_values->map() == |
- isolate()->heap()->fixed_cow_array_map()) { |
- __ IncrementCounter(isolate()->counters()->cow_arrays_created_stub(), |
- 1); |
- } |
- FastCloneShallowArrayStub stub( |
- FastCloneShallowArrayStub::CLONE_ANY_ELEMENTS, length); |
+ // If the elements are already FAST_ELEMENTS, the boilerplate cannot |
+ // change, so it's possible to specialize the stub in advance. |
+ FastCloneShallowArrayStub::Mode mode = has_constant_fast_elements |
+ ? FastCloneShallowArrayStub::CLONE_ELEMENTS |
+ : FastCloneShallowArrayStub::CLONE_ANY_ELEMENTS; |
+ FastCloneShallowArrayStub stub(mode, length); |
__ CallStub(&stub); |
} |