Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 8590024: Introduced git+http(s) fake URL schema to support git urls which don't have "filename.git" portio... (Closed)

Created:
9 years, 1 month ago by igorgatis
Modified:
9 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Introduced git+http(s) fake URL schema to support git urls which don't have "filename.git" portion (http://foo/bar vs http://foo/bar/filename.git). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M gclient_scm.py View 2 chunks +7 lines, -0 lines 0 comments Download
M tests/gclient_scm_test.py View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
Thanks, but I didn't see you signing the CLA. Can you do it first? http://code.google.com/legal/individual-cla-v1.0.html ...
9 years, 1 month ago (2011-11-17 12:27:58 UTC) #1
igorgatis
done. On Thu, Nov 17, 2011 at 10:27, <maruel@chromium.org> wrote: > Thanks, but I didn't ...
9 years, 1 month ago (2011-11-17 12:32:49 UTC) #2
M-A Ruel
lgtm, thanks! I'll commit it tomorrow as today I have very limited internet access. You'll ...
9 years, 1 month ago (2011-11-17 12:35:34 UTC) #3
igorgatis
Cool. Thanks! On Thu, Nov 17, 2011 at 10:35, <maruel@chromium.org> wrote: > lgtm, thanks! > ...
9 years, 1 month ago (2011-11-17 12:50:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igorgatis@gmail.com/8590024/1
9 years, 1 month ago (2011-11-21 16:28:52 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 16:35:10 UTC) #6
Change committed as 110937

Powered by Google App Engine
This is Rietveld 408576698