Work around wrong UA sniffing by Yahoo! JAPAN

webkit/glue/webkit_glue.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webkit_glue.h"
 
 #if defined(OS_WIN)
 #include <objidl.h>
 #include <mlang.h>
 #elif defined(OS_POSIX) && !defined(OS_MACOSX)
@@ skipping 332 matching lines @@
 class UserAgentState {
  public:
   UserAgentState();
   ~UserAgentState();
 
   void Set(const std::string& user_agent, bool overriding);
   const std::string& Get(const GURL& url) const;
 
  private:
   mutable std::string user_agent_;
-  // The UA string when we're pretending to be Mac Safari.
-  mutable std::string mimic_mac_safari_user_agent_;
+  // The UA string when we're pretending to be Mac Safari or Win Firefox.
+  mutable std::string user_agent_for_spoofing_hack_;
 
   mutable bool user_agent_requested_;
   bool user_agent_is_overridden_;
 
   // This object can be accessed from multiple threads, so use a lock around
   // accesses to the data members.
   mutable base::Lock lock_;
 };
 
 UserAgentState::UserAgentState()
@@ skipping 21 matching lines @@
 
 const std::string& UserAgentState::Get(const GURL& url) const {
   base::AutoLock auto_lock(lock_);
   user_agent_requested_ = true;
 
   DCHECK(!user_agent_.empty());
 
   // Workarounds for sites that use misguided UA sniffing.
   if (!user_agent_is_overridden_) {
 #if defined(OS_MACOSX)
-    if (url.host() == "www.microsoft.com" &&
-        StartsWithASCII(url.path(), "/getsilverlight", false)) {
+    if ((url.host() == "www.microsoft.com" &&
+         StartsWithASCII(url.path(), "/getsilverlight", false)) ||
+        // Problematic Yahoo! JAPAN pages
+        (url.host() == "headlines.yahoo.co.jp" &&
+         StartsWithASCII(url.path(), "/videonews/", true)) ||
+        (url.host() == "downloads.yahoo.co.jp" &&
+         StartsWithASCII(url.path(), "/docs/silverlight/", true)) ||
+        url.host() == "gyao.yahoo.co.jp") {

[tony, 2011/11/18 18:35:10]

Please make a helper function for the yahoo cases.  Something like,

bool IsYahooSiteThatNeedsSpoofing(const GURL& url) {
  if (url.host() == "headlines.yahoo.co.jp" &&
      StartsWithASCII(url.path(), "/videonews/", true)) {
    return true;
  }
#if defined(OS_MACOSX)
  if (url.host() == "downloads.yahoo.co.jp" &&
      StartsWithASCII(url.path(), "/docs/silverlight/", true)) ||
      url.host() == "gyao.yahoo.co.jp") {
    return true;
#elif defined(OS_WIN)
  if (url.host() == "weather.yahoo.co.jp" &&
      StartsWithASCII(url.path(), "/weather/zoomradar/", true)) {
    return true;
  }
#endif
  return false;
}

[Yuzo, 2011/11/21 02:22:01]

Done.

       // The landing page for updating Silverlight gives a confusing experience
       // in browsers that Silverlight doesn't officially support; spoof as
       // Safari to reduce the chance that users won't complete updates.
       // Should be removed if the sniffing is removed: http://crbug.com/88211
-      if (mimic_mac_safari_user_agent_.empty()) {
-        mimic_mac_safari_user_agent_ =
+
+      // The above Yahoo! JAPAN pages erroneously judge that Silverlight does
+      // not support Chromium. Until the pages are fixed, spoof the UA.
+      // http://crbug.com/104426
+      if (user_agent_for_spoofing_hack_.empty()) {
+        user_agent_for_spoofing_hack_ =
             BuildUserAgentFromProduct("Version/5.0.4 Safari/533.20.27");
       }
-      return mimic_mac_safari_user_agent_;
+      return user_agent_for_spoofing_hack_;
+    }
+#elif defined(OS_WIN)
+    if ((url.host() == "headlines.yahoo.co.jp" &&
+         StartsWithASCII(url.path(), "/videonews/", true)) ||
+        (url.host() == "weather.yahoo.co.jp" &&
+         StartsWithASCII(url.path(), "/weather/zoomradar/", true)) ||
+        url.host() == "promotion.shopping.yahoo.co.jp") {
+      // The above Yahoo! JAPAN pages erroneously judge that Silverlight does
+      // not support Chromium. Until the pages are fixed, spoof the UA.
+      // Note that the set of the pages can be different from that for Mac.
+      // http://crbug.com/104426
+      if (user_agent_for_spoofing_hack_.empty()) {
+        // Pretend to be Firefox. Mac Safari doesn't support Silverlight.
+        user_agent_for_spoofing_hack_ =
+            "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 "
+            "Firefox/8.0";
+      }
+      return user_agent_for_spoofing_hack_;
     }
 #endif
   }
 
   return user_agent_;
 }
 
 base::LazyInstance<UserAgentState> g_user_agent = LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace
@@ skipping 32 matching lines @@
 std::string GetInspectorProtocolVersion() {
   return WebDevToolsAgent::inspectorProtocolVersion().utf8();
 }
 
 bool IsInspectorProtocolVersionSupported(const std::string& version) {
   return WebDevToolsAgent::supportsInspectorProtocolVersion(
       WebString::fromUTF8(version));
 }
 
 } // namespace webkit_glue