Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 8590020: Make files created in base::PlatformFile readable by grp and oth on ChromeOS (Closed)

Created:
9 years, 1 month ago by tbarzic
Modified:
9 years, 1 month ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Create files readable by grp and oth in base::PlatformFile for posix. Main motivation for this is webkit's createFile. While creating files with permission 0600 is not an issue on other platforms, on ChromeOs FileBrowser may access external filesystem, so it makes sense to create files with permission 0644. Further more creating files with mode 0600 on ChromeOS external fielsystem may cause some problems with zip file support (see bug). Note this is M16 release blocker... BUG=chromium-os:22263 TEST=linux_chromeos trybots verified copying files in FileBrowser on ChromeOs creates files with permission 644 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110740

Patch Set 1 #

Patch Set 2 : "" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M base/platform_file_posix.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tbarzic
hi guys, could you please have a look at this...
9 years, 1 month ago (2011-11-17 04:18:45 UTC) #1
rvargas (doing something else)
LGTM.
9 years, 1 month ago (2011-11-17 22:43:55 UTC) #2
ericu
LGTM.
9 years, 1 month ago (2011-11-17 23:12:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8590020/1
9 years, 1 month ago (2011-11-18 04:32:05 UTC) #4
commit-bot: I haz the power
Presubmit check for 8590020-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-18 04:32:08 UTC) #5
tbarzic
9 years, 1 month ago (2011-11-18 04:45:49 UTC) #6
darin (slow to review)
LGTM
9 years, 1 month ago (2011-11-18 07:27:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8590020/1
9 years, 1 month ago (2011-11-18 17:48:19 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-18 19:47:43 UTC) #9
Try job failure for 8590020-1 (retry) (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698