Issue 8590016: Move the PluginDataRemover class to content, and remove the chrome pieces from it. This class rea...

Issue 8590016: Move the PluginDataRemover class to content, and remove the chrome pieces from it. This class rea... (Closed)

Created:
9 years, 1 month ago by jam

Modified:
9 years, 1 month ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move the PluginDataRemover class to content, and remove the chrome pieces from it. This class really belongs in content because it's part of the web platform. I've also wrapped it with an interface that is used by chrome. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110530

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 6

Patch Set 5 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -502 lines)			Patch
M	chrome/browser/browsing_data_remover.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/browsing_data_remover.cc	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_clear_api.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/plugin_data_remover.h	View		1 chunk	+0 lines, -96 lines	0 comments	Download
D	chrome/browser/plugin_data_remover.cc	View		1 chunk	+0 lines, -200 lines	0 comments	Download
D	chrome/browser/plugin_data_remover_browsertest.cc	View		1 chunk	+0 lines, -52 lines	0 comments	Download
M	chrome/browser/plugin_data_remover_helper.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/plugin_data_remover_helper.cc	View		4 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/workers_ui.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A +	content/browser/plugin_data_remover_impl.h	View	1 2 3 4	4 chunks	+18 lines, -39 lines	0 comments	Download
A +	content/browser/plugin_data_remover_impl.cc	View	1 2 3 4	4 chunks	+60 lines, -70 lines	0 comments	Download
A +	content/browser/plugin_data_remover_impl_browsertest.cc	View		3 chunks	+7 lines, -14 lines	0 comments	Download
M	content/content_browser.gypi	View		3 chunks	+17 lines, -14 lines	0 comments	Download
A	content/public/browser/plugin_data_remover.h	View	1 2 3 4	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

LGTM w/ some nits: http://codereview.chromium.org/8590016/diff/5026/chrome/browser/ui/webui/workers_ui.cc File chrome/browser/ui/webui/workers_ui.cc (left): http://codereview.chromium.org/8590016/diff/5026/chrome/browser/ui/webui/workers_ui.cc#oldcode24 chrome/browser/ui/webui/workers_ui.cc:24: #include "content/common/devtools_messages.h" Is this related ...

9 years, 1 month ago (2011-11-17 10:41:10 UTC) #2

jam

9 years, 1 month ago (2011-11-17 16:49:51 UTC) #3

http://codereview.chromium.org/8590016/diff/5026/chrome/browser/ui/webui/work...
File chrome/browser/ui/webui/workers_ui.cc (left):

http://codereview.chromium.org/8590016/diff/5026/chrome/browser/ui/webui/work...
chrome/browser/ui/webui/workers_ui.cc:24: #include
"content/common/devtools_messages.h"
On 2011/11/17 10:41:10, Bernhard Bauer wrote:
> Is this related to this CL?

ah yes, it is. seems harmless to leave in

http://codereview.chromium.org/8590016/diff/5026/content/browser/plugin_data_...
File content/browser/plugin_data_remover_impl.cc (right):

http://codereview.chromium.org/8590016/diff/5026/content/browser/plugin_data_...
content/browser/plugin_data_remover_impl.cc:30: //static
On 2011/11/17 10:41:10, Bernhard Bauer wrote:
> Nit: Space after //

Done.

http://codereview.chromium.org/8590016/diff/5026/content/browser/plugin_data_...
content/browser/plugin_data_remover_impl.cc:96: void
PluginDataRemoverImpl::Wait() {
On 2011/11/17 10:41:10, Bernhard Bauer wrote:
> This method is not used anymore (it was used to wait at shutdown when "clear
> cookies on exit" was checked), but we've changed the behavior since, so you
> could remove it.

Done.

Expand Messages | Collapse Messages